Skip to content

Commit d70ddd7

Browse files
Mel Gormantorvalds
authored andcommitted
mm: page_alloc: pass PFN to __free_pages_bootmem
__free_pages_bootmem prepares a page for release to the buddy allocator and assumes that the struct page is initialised. Parallel initialisation of struct pages defers initialisation and __free_pages_bootmem can be called for struct pages that cannot yet map struct page to PFN. This patch passes PFN to __free_pages_bootmem with no other functional change. Signed-off-by: Mel Gorman <[email protected]> Tested-by: Nate Zimmer <[email protected]> Tested-by: Waiman Long <[email protected]> Tested-by: Daniel J Blueman <[email protected]> Acked-by: Pekka Enberg <[email protected]> Cc: Robin Holt <[email protected]> Cc: Nate Zimmer <[email protected]> Cc: Dave Hansen <[email protected]> Cc: Waiman Long <[email protected]> Cc: Scott Norton <[email protected]> Cc: "Luck, Tony" <[email protected]> Cc: Ingo Molnar <[email protected]> Cc: "H. Peter Anvin" <[email protected]> Cc: Thomas Gleixner <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent 92923ca commit d70ddd7

File tree

5 files changed

+14
-11
lines changed

5 files changed

+14
-11
lines changed

mm/bootmem.c

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -164,15 +164,15 @@ void __init free_bootmem_late(unsigned long physaddr, unsigned long size)
164164
end = PFN_DOWN(physaddr + size);
165165

166166
for (; cursor < end; cursor++) {
167-
__free_pages_bootmem(pfn_to_page(cursor), 0);
167+
__free_pages_bootmem(pfn_to_page(cursor), cursor, 0);
168168
totalram_pages++;
169169
}
170170
}
171171

172172
static unsigned long __init free_all_bootmem_core(bootmem_data_t *bdata)
173173
{
174174
struct page *page;
175-
unsigned long *map, start, end, pages, count = 0;
175+
unsigned long *map, start, end, pages, cur, count = 0;
176176

177177
if (!bdata->node_bootmem_map)
178178
return 0;
@@ -210,17 +210,17 @@ static unsigned long __init free_all_bootmem_core(bootmem_data_t *bdata)
210210
if (IS_ALIGNED(start, BITS_PER_LONG) && vec == ~0UL) {
211211
int order = ilog2(BITS_PER_LONG);
212212

213-
__free_pages_bootmem(pfn_to_page(start), order);
213+
__free_pages_bootmem(pfn_to_page(start), start, order);
214214
count += BITS_PER_LONG;
215215
start += BITS_PER_LONG;
216216
} else {
217-
unsigned long cur = start;
217+
cur = start;
218218

219219
start = ALIGN(start + 1, BITS_PER_LONG);
220220
while (vec && cur != start) {
221221
if (vec & 1) {
222222
page = pfn_to_page(cur);
223-
__free_pages_bootmem(page, 0);
223+
__free_pages_bootmem(page, cur, 0);
224224
count++;
225225
}
226226
vec >>= 1;
@@ -229,12 +229,13 @@ static unsigned long __init free_all_bootmem_core(bootmem_data_t *bdata)
229229
}
230230
}
231231

232+
cur = bdata->node_min_pfn;
232233
page = virt_to_page(bdata->node_bootmem_map);
233234
pages = bdata->node_low_pfn - bdata->node_min_pfn;
234235
pages = bootmem_bootmap_pages(pages);
235236
count += pages;
236237
while (pages--)
237-
__free_pages_bootmem(page++, 0);
238+
__free_pages_bootmem(page++, cur++, 0);
238239

239240
bdebug("nid=%td released=%lx\n", bdata - bootmem_node_data, count);
240241

mm/internal.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,8 @@ __find_buddy_index(unsigned long page_idx, unsigned int order)
155155
}
156156

157157
extern int __isolate_free_page(struct page *page, unsigned int order);
158-
extern void __free_pages_bootmem(struct page *page, unsigned int order);
158+
extern void __free_pages_bootmem(struct page *page, unsigned long pfn,
159+
unsigned int order);
159160
extern void prep_compound_page(struct page *page, unsigned long order);
160161
#ifdef CONFIG_MEMORY_FAILURE
161162
extern bool is_free_buddy_page(struct page *page);

mm/memblock.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1419,7 +1419,7 @@ void __init __memblock_free_late(phys_addr_t base, phys_addr_t size)
14191419
end = PFN_DOWN(base + size);
14201420

14211421
for (; cursor < end; cursor++) {
1422-
__free_pages_bootmem(pfn_to_page(cursor), 0);
1422+
__free_pages_bootmem(pfn_to_page(cursor), cursor, 0);
14231423
totalram_pages++;
14241424
}
14251425
}

mm/nobootmem.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ void __init free_bootmem_late(unsigned long addr, unsigned long size)
8686
end = PFN_DOWN(addr + size);
8787

8888
for (; cursor < end; cursor++) {
89-
__free_pages_bootmem(pfn_to_page(cursor), 0);
89+
__free_pages_bootmem(pfn_to_page(cursor), cursor, 0);
9090
totalram_pages++;
9191
}
9292
}
@@ -101,7 +101,7 @@ static void __init __free_pages_memory(unsigned long start, unsigned long end)
101101
while (start + (1UL << order) > end)
102102
order--;
103103

104-
__free_pages_bootmem(pfn_to_page(start), order);
104+
__free_pages_bootmem(pfn_to_page(start), start, order);
105105

106106
start += (1UL << order);
107107
}

mm/page_alloc.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -878,7 +878,8 @@ static void __free_pages_ok(struct page *page, unsigned int order)
878878
local_irq_restore(flags);
879879
}
880880

881-
void __init __free_pages_bootmem(struct page *page, unsigned int order)
881+
void __init __free_pages_bootmem(struct page *page, unsigned long pfn,
882+
unsigned int order)
882883
{
883884
unsigned int nr_pages = 1 << order;
884885
struct page *p = page;

0 commit comments

Comments
 (0)