FogBugz #229601: newhaven lcd: fix kbuild test robot warnings

The kbuild test robot noticed some problems with the newhaven
lcd driver.

1. lcd_of_match is not NULL terminated at line 606

2. Use ARRAY_SIZE instead of dividing sizeof array with sizeof an element

3. Random config test warnings:
   drivers/built-in.o: In function `brightness_store':
>> newhaven_lcd.c:(.text+0xd2225): undefined reference to
  `i2c_master_send'
   drivers/built-in.o: In function `lcd_init':
>> newhaven_lcd.c:(.init.text+0x8a9e): undefined reference to
   `i2c_register_driver'
   drivers/built-in.o: In function `lcd_exit':
>> newhaven_lcd.c:(.exit.text+0x439): undefined reference to
   `i2c_del_driver'
   drivers/built-in.o: In function `lcd_remove':
>> newhaven_lcd.c:(.exit.text+0x462): undefined reference to
   `i2c_master_send'

This patch squashes the two patches they kindly sent us plus adds
a Kconfig fix for the warnings in #3 above.

Signed-off-by: Fengguang Wu <[email protected]>
Signed-off-by: Alan Tull <[email protected]>

Author: Fengguang Wu

drivers/tty/Kconfig

@@ -177,6 +177,7 @@ config BFIN_JTAG_COMM_CONSOLE
 
 config NEWHAVEN_LCD
        tristate "NEWHAVEN LCD"
+       depends on I2C
        help
          Add support for a TTY device on a Newhaven I2C LCD device.
 

drivers/tty/newhaven_lcd.c

@@ -142,7 +142,7 @@ static int lcd_load_custom_fonts(struct lcd *lcd_data)
 	u8 buf[LCD_BYTES_PER_FONT_CMD];
 	int count, i;
 
-	for (i = 0; i < sizeof(custom_fonts) / sizeof(struct custom_font) ; i++) {
+	for (i = 0; i < ARRAY_SIZE(custom_fonts); i++) {
 		buf[0] = LCD_COMMAND;
 		buf[1] = LCD_CUSTOM_CHAR;
 		buf[2] = custom_fonts[i].mapping;
@@ -604,6 +604,7 @@ static int __exit lcd_remove(struct i2c_client *client)
 
 static const struct of_device_id lcd_of_match[] = {
 	{ .compatible = "newhaven,nhd-0216k3z-nsw-bbw", },
+	{},
 };
 
 static const struct i2c_device_id lcd_id[] = {