Skip to content

Commit c9bfcb3

Browse files
Joakim Tjernlundtorvalds
authored andcommitted
spi_mpc83xx: much improved driver
The current driver may cause glitches on SPI CLK line since one must disable the SPI controller before changing any HW settings. Fix this by implementing a local spi_transfer function that won't change speed and/or word size while CS is active. While doing that heavy lifting a few other issues were addressed too: - Make word size 16 and 32 work too. - Honor bits_per_word and speed_hz in spi transaction. - Optimize the common path. This also stops using the "bitbang" framework (except for a few constants). [Roel Kluin <[email protected]>: "irq" needs to be signed] Signed-off-by: Joakim Tjernlund <[email protected]> Signed-off-by: David Brownell <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent f4ed0de commit c9bfcb3

File tree

2 files changed

+282
-130
lines changed

2 files changed

+282
-130
lines changed

drivers/spi/Kconfig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,6 @@ config SPI_MPC52xx_PSC
126126
config SPI_MPC83xx
127127
tristate "Freescale MPC83xx/QUICC Engine SPI controller"
128128
depends on SPI_MASTER && (PPC_83xx || QUICC_ENGINE) && EXPERIMENTAL
129-
select SPI_BITBANG
130129
help
131130
This enables using the Freescale MPC83xx and QUICC Engine SPI
132131
controllers in master mode.

0 commit comments

Comments
 (0)