Skip to content

Commit b1312b8

Browse files
Fengguang Wudavem330
authored andcommitted
net: dsa: mv88e6xxx: fix boolreturn.cocci warnings
drivers/net/dsa/mv88e6xxx/serdes.c:66:9-10: WARNING: return of 0/1 in function 'mv88e6352_port_has_serdes' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci Fixes: eb755c3 ("net: dsa: mv88e6xxx: Add helper to determining if port has SERDES") CC: Andrew Lunn <[email protected]> Signed-off-by: Fengguang Wu <[email protected]> Reviewed-by: Andrew Lunn <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 630b21a commit b1312b8

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/net/dsa/mv88e6xxx/serdes.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,15 +63,15 @@ static bool mv88e6352_port_has_serdes(struct mv88e6xxx_chip *chip, int port)
6363
err = mv88e6xxx_port_get_cmode(chip, port, &cmode);
6464
if (err) {
6565
dev_err(chip->dev, "failed to read cmode\n");
66-
return 0;
66+
return false;
6767
}
6868

6969
if ((cmode == MV88E6XXX_PORT_STS_CMODE_100BASE_X) ||
7070
(cmode == MV88E6XXX_PORT_STS_CMODE_1000BASE_X) ||
7171
(cmode == MV88E6XXX_PORT_STS_CMODE_SGMII))
72-
return 1;
72+
return true;
7373

74-
return 0;
74+
return false;
7575
}
7676

7777
int mv88e6352_serdes_power(struct mv88e6xxx_chip *chip, int port, bool on)

0 commit comments

Comments
 (0)