Skip to content

Commit afe3eb6

Browse files
jhovoldgregkh
authored andcommitted
serdev: ttyport: do not used keyed wakeup in write_wakeup
Serdev does not use the file abstraction and specifically there will never be anyone polling a file descriptor for POLLOUT events. Just use plain wake_up_interruptible() in the write_wakeup callback and document why it's there. Signed-off-by: Johan Hovold <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 19ac50f commit afe3eb6

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/tty/serdev/serdev-ttyport.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,8 @@ static void ttyport_write_wakeup(struct tty_port *port)
5959
test_bit(SERPORT_ACTIVE, &serport->flags))
6060
serdev_controller_write_wakeup(ctrl);
6161

62-
wake_up_interruptible_poll(&tty->write_wait, POLLOUT);
62+
/* Wake up any tty_wait_until_sent() */
63+
wake_up_interruptible(&tty->write_wait);
6364

6465
tty_kref_put(tty);
6566
}

0 commit comments

Comments
 (0)