Skip to content

Commit af7d23f

Browse files
Yang Yingliangdavem330
authored andcommitted
octeontx2-pf: mcs: fix possible memory leak in otx2_probe()
In error path after calling cn10k_mcs_init(), cn10k_mcs_free() need be called to avoid memory leak. Fixes: c54ffc7 ("octeontx2-pf: mcs: Introduce MACSEC hardware offloading") Signed-off-by: Yang Yingliang <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 84cdf5b commit af7d23f

File tree

1 file changed

+3
-1
lines changed
  • drivers/net/ethernet/marvell/octeontx2/nic

1 file changed

+3
-1
lines changed

drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2810,7 +2810,7 @@ static int otx2_probe(struct pci_dev *pdev, const struct pci_device_id *id)
28102810
err = register_netdev(netdev);
28112811
if (err) {
28122812
dev_err(dev, "Failed to register netdevice\n");
2813-
goto err_del_mcam_entries;
2813+
goto err_mcs_free;
28142814
}
28152815

28162816
err = otx2_wq_init(pf);
@@ -2849,6 +2849,8 @@ static int otx2_probe(struct pci_dev *pdev, const struct pci_device_id *id)
28492849
otx2_mcam_flow_del(pf);
28502850
err_unreg_netdev:
28512851
unregister_netdev(netdev);
2852+
err_mcs_free:
2853+
cn10k_mcs_free(pf);
28522854
err_del_mcam_entries:
28532855
otx2_mcam_flow_del(pf);
28542856
err_ptp_destroy:

0 commit comments

Comments
 (0)