Skip to content

Commit a4c30a4

Browse files
author
Hans Verkuil
committed
drm_dp_mst_topology: fix broken drm_dp_sideband_parse_remote_dpcd_read()
When parsing the reply of a DP_REMOTE_DPCD_READ DPCD command the result is wrong due to a missing idx increment. This was never noticed since DP_REMOTE_DPCD_READ is currently not used, but if you enable it, then it is all wrong. Signed-off-by: Hans Verkuil <[email protected]> Reviewed-by: Lyude Paul <[email protected]> Acked-by: Alex Deucher <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 9bcf6d9 commit a4c30a4

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/gpu/drm/drm_dp_mst_topology.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -439,6 +439,7 @@ static bool drm_dp_sideband_parse_remote_dpcd_read(struct drm_dp_sideband_msg_rx
439439
if (idx > raw->curlen)
440440
goto fail_len;
441441
repmsg->u.remote_dpcd_read_ack.num_bytes = raw->msg[idx];
442+
idx++;
442443
if (idx > raw->curlen)
443444
goto fail_len;
444445

0 commit comments

Comments
 (0)