Skip to content

Commit a120d9a

Browse files
Colin Ian Kingdavem330
authored andcommitted
netxen: fix incorrect loop counter decrement
The loop counter k is currently being decremented from zero which is incorrect. Fix this by incrementing k instead Detected by CoverityScan, CID#401847 ("Infinite loop") Fixes: 83f18a5 ("netxen_nic: fw dump support") Signed-off-by: Colin Ian King <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent eac2c68 commit a120d9a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2311,7 +2311,7 @@ netxen_md_rdqueue(struct netxen_adapter *adapter,
23112311
loop_cnt++) {
23122312
NX_WR_DUMP_REG(select_addr, adapter->ahw.pci_base0, queue_id);
23132313
read_addr = queueEntry->read_addr;
2314-
for (k = 0; k < read_cnt; k--) {
2314+
for (k = 0; k < read_cnt; k++) {
23152315
NX_RD_DUMP_REG(read_addr, adapter->ahw.pci_base0,
23162316
&read_value);
23172317
*data_buff++ = read_value;

0 commit comments

Comments
 (0)