Skip to content

Commit 9ebae9e

Browse files
Alan Coxhtejun
authored andcommitted
pata_ninja32: Avoid corrupting status flags
Ninja32 needs to set some flags to indicate it does 32bit IO. However it currently assigns this which loses the initializing flag and causes a warning spew. Fix it to use a logical or as is intended. Signed-off-by: Alan Cox <[email protected]> Tested-by: Ellmar Stelnberger <[email protected]> Signed-off-by: Tejun Heo <[email protected]>
1 parent 9b4b3f6 commit 9ebae9e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/ata/pata_ninja32.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ static int ninja32_init_one(struct pci_dev *dev, const struct pci_device_id *id)
144144
ap->ioaddr.altstatus_addr = base + 0x1E;
145145
ap->ioaddr.bmdma_addr = base;
146146
ata_sff_std_ports(&ap->ioaddr);
147-
ap->pflags = ATA_PFLAG_PIO32 | ATA_PFLAG_PIO32CHANGE;
147+
ap->pflags |= ATA_PFLAG_PIO32 | ATA_PFLAG_PIO32CHANGE;
148148

149149
ninja32_program(base);
150150
/* FIXME: Should we disable them at remove ? */

0 commit comments

Comments
 (0)