Skip to content

Commit 9d2c27e

Browse files
danielinuxdavem330
authored andcommitted
tcp: Fix tcp_hybla zero congestion window growth with small rho and large cwnd.
Because of rounding, in certain conditions, i.e. when in congestion avoidance state rho is smaller than 1/128 of the current cwnd, TCP Hybla congestion control starves and the cwnd is kept constant forever. This patch forces an increment by one segment after #send_cwnd calls without increments(newreno behavior). Signed-off-by: Daniele Lacamera <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 58ec3b4 commit 9d2c27e

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

net/ipv4/tcp_hybla.c

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,11 @@ static void hybla_cong_avoid(struct sock *sk, u32 ack, u32 in_flight)
150150
ca->snd_cwnd_cents -= 128;
151151
tp->snd_cwnd_cnt = 0;
152152
}
153-
153+
/* check when cwnd has not been incremented for a while */
154+
if (increment == 0 && odd == 0 && tp->snd_cwnd_cnt >= tp->snd_cwnd) {
155+
tp->snd_cwnd++;
156+
tp->snd_cwnd_cnt = 0;
157+
}
154158
/* clamp down slowstart cwnd to ssthresh value. */
155159
if (is_slowstart)
156160
tp->snd_cwnd = min(tp->snd_cwnd, tp->snd_ssthresh);

0 commit comments

Comments
 (0)