Skip to content

Commit 9b09456

Browse files
Dan CarpenterKalle Valo
authored andcommitted
ath11k: Fix error code in ath11k_core_suspend()
The "if (!ret)" condition is inverted and it should be "if (ret)". It means that we return success when we had intended to return an error code. This also caused a spurious warning even when the suspend was successful: [ 297.186612] ath11k_pci 0000:06:00.0: failed to suspend hif: 0 Fixes: d1b0c33 ("ath11k: implement suspend for QCA6390 PCI devices") Signed-off-by: Dan Carpenter <[email protected]> Signed-off-by: Kalle Valo <[email protected]> Link: https://lore.kernel.org/r/X9nF17L2/EKOSbn/@mwanda
1 parent aa44b2f commit 9b09456

File tree

1 file changed

+1
-1
lines changed
  • drivers/net/wireless/ath/ath11k

1 file changed

+1
-1
lines changed

drivers/net/wireless/ath/ath11k/core.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ int ath11k_core_suspend(struct ath11k_base *ab)
185185
ath11k_hif_ce_irq_disable(ab);
186186

187187
ret = ath11k_hif_suspend(ab);
188-
if (!ret) {
188+
if (ret) {
189189
ath11k_warn(ab, "failed to suspend hif: %d\n", ret);
190190
return ret;
191191
}

0 commit comments

Comments
 (0)