Skip to content

Commit 99a2b9b

Browse files
ben-ishaySaeed Mahameed
authored andcommitted
net/mlx5e: SHAMPO, reduce TIR indication
SHAMPO is an RQ / WQ feature, an indication was added to the TIR in the first place to enforce suitability between connected TIR and RQ, this enforcement does not exist in current the Firmware implementation and was redundant in the first place. Fixes: 83439f3 ("net/mlx5e: Add HW-GRO offload") Signed-off-by: Ben Ben-Ishay <[email protected]> Signed-off-by: Saeed Mahameed <[email protected]>
1 parent ad11c4f commit 99a2b9b

File tree

3 files changed

+1
-6
lines changed

3 files changed

+1
-6
lines changed

drivers/net/ethernet/mellanox/mlx5/core/en/tir.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,9 +88,6 @@ void mlx5e_tir_builder_build_packet_merge(struct mlx5e_tir_builder *builder,
8888
(MLX5E_PARAMS_DEFAULT_LRO_WQE_SZ - rough_max_l2_l3_hdr_sz) >> 8);
8989
MLX5_SET(tirc, tirc, lro_timeout_period_usecs, pkt_merge_param->timeout);
9090
break;
91-
case MLX5E_PACKET_MERGE_SHAMPO:
92-
MLX5_SET(tirc, tirc, packet_merge_mask, MLX5_TIRC_PACKET_MERGE_MASK_SHAMPO);
93-
break;
9491
default:
9592
break;
9693
}

drivers/net/ethernet/mellanox/mlx5/core/en_main.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3616,8 +3616,7 @@ static int set_feature_hw_gro(struct net_device *netdev, bool enable)
36163616
goto out;
36173617
}
36183618

3619-
err = mlx5e_safe_switch_params(priv, &new_params,
3620-
mlx5e_modify_tirs_packet_merge_ctx, NULL, reset);
3619+
err = mlx5e_safe_switch_params(priv, &new_params, NULL, NULL, reset);
36213620
out:
36223621
mutex_unlock(&priv->state_lock);
36233622
return err;

include/linux/mlx5/mlx5_ifc.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3434,7 +3434,6 @@ enum {
34343434
enum {
34353435
MLX5_TIRC_PACKET_MERGE_MASK_IPV4_LRO = BIT(0),
34363436
MLX5_TIRC_PACKET_MERGE_MASK_IPV6_LRO = BIT(1),
3437-
MLX5_TIRC_PACKET_MERGE_MASK_SHAMPO = BIT(2),
34383437
};
34393438

34403439
enum {

0 commit comments

Comments
 (0)