Skip to content

Commit 8f35eaa

Browse files
Andrew Murraywilldeacon
authored andcommitted
jump_label: Don't warn on __exit jump entries
On architectures that discard .exit.* sections at runtime, a warning is printed for each jump label that is used within an in-kernel __exit annotated function: can't patch jump_label at ehci_hcd_cleanup+0x8/0x3c WARNING: CPU: 0 PID: 1 at kernel/jump_label.c:410 __jump_label_update+0x12c/0x138 As these functions will never get executed (they are free'd along with the rest of initmem) - we do not need to patch them and should not display any warnings. The warning is displayed because the test required to satisfy jump_entry_is_init is based on init_section_contains (__init_begin to __init_end) whereas the test in __jump_label_update is based on init_kernel_text (_sinittext to _einittext) via kernel_text_address). Fixes: 1948367 ("jump_label: Annotate entries that operate on __init code earlier") Signed-off-by: Andrew Murray <[email protected]> Acked-by: Peter Zijlstra (Intel) <[email protected]> Acked-by: Mark Rutland <[email protected]> Signed-off-by: Will Deacon <[email protected]>
1 parent e21a712 commit 8f35eaa

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

kernel/jump_label.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -407,7 +407,9 @@ static bool jump_label_can_update(struct jump_entry *entry, bool init)
407407
return false;
408408

409409
if (!kernel_text_address(jump_entry_code(entry))) {
410-
WARN_ONCE(1, "can't patch jump_label at %pS", (void *)jump_entry_code(entry));
410+
WARN_ONCE(!jump_entry_is_init(entry),
411+
"can't patch jump_label at %pS",
412+
(void *)jump_entry_code(entry));
411413
return false;
412414
}
413415

0 commit comments

Comments
 (0)