Skip to content

Commit 8a1e918

Browse files
kubalewskianguy11
authored andcommitted
i40e: Fix sparse warning: missing error code 'err'
Set proper return values inside error checking if-statements. Previously following warning was produced when compiling against sparse. i40e_main.c:15162 i40e_init_recovery_mode() warn: missing error code 'err' Fixes: 4ff0ee1 ("i40e: Introduce recovery mode support") Signed-off-by: Aleksandr Loktionov <[email protected]> Signed-off-by: Arkadiusz Kubalewski <[email protected]> Tested-by: Dave Switzer <[email protected]> Signed-off-by: Tony Nguyen <[email protected]>
1 parent 6b5674f commit 8a1e918

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

drivers/net/ethernet/intel/i40e/i40e_main.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15138,12 +15138,16 @@ static int i40e_init_recovery_mode(struct i40e_pf *pf, struct i40e_hw *hw)
1513815138
* in order to register the netdev
1513915139
*/
1514015140
v_idx = i40e_vsi_mem_alloc(pf, I40E_VSI_MAIN);
15141-
if (v_idx < 0)
15141+
if (v_idx < 0) {
15142+
err = v_idx;
1514215143
goto err_switch_setup;
15144+
}
1514315145
pf->lan_vsi = v_idx;
1514415146
vsi = pf->vsi[v_idx];
15145-
if (!vsi)
15147+
if (!vsi) {
15148+
err = -EFAULT;
1514615149
goto err_switch_setup;
15150+
}
1514715151
vsi->alloc_queue_pairs = 1;
1514815152
err = i40e_config_netdev(vsi);
1514915153
if (err)

0 commit comments

Comments
 (0)