Skip to content

Commit 892d2a5

Browse files
Zorro Langdjwong
authored andcommitted
xfs: bad assertion for delalloc an extent that start at i_size
By run fsstress long enough time enough in RHEL-7, I find an assertion failure (harder to reproduce on linux-4.11, but problem is still there): XFS: Assertion failed: (iflags & BMV_IF_DELALLOC) != 0, file: fs/xfs/xfs_bmap_util.c The assertion is in xfs_getbmap() funciton: if (map[i].br_startblock == DELAYSTARTBLOCK && --> map[i].br_startoff <= XFS_B_TO_FSB(mp, XFS_ISIZE(ip))) ASSERT((iflags & BMV_IF_DELALLOC) != 0); When map[i].br_startoff == XFS_B_TO_FSB(mp, XFS_ISIZE(ip)), the startoff is just at EOF. But we only need to make sure delalloc extents that are within EOF, not include EOF. Signed-off-by: Zorro Lang <[email protected]> Reviewed-by: Brian Foster <[email protected]> Reviewed-by: Darrick J. Wong <[email protected]> Signed-off-by: Darrick J. Wong <[email protected]>
1 parent 6e74750 commit 892d2a5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

fs/xfs/xfs_bmap_util.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -716,7 +716,7 @@ xfs_getbmap(
716716
* extents.
717717
*/
718718
if (map[i].br_startblock == DELAYSTARTBLOCK &&
719-
map[i].br_startoff <= XFS_B_TO_FSB(mp, XFS_ISIZE(ip)))
719+
map[i].br_startoff < XFS_B_TO_FSB(mp, XFS_ISIZE(ip)))
720720
ASSERT((iflags & BMV_IF_DELALLOC) != 0);
721721

722722
if (map[i].br_startblock == HOLESTARTBLOCK &&

0 commit comments

Comments
 (0)