Skip to content

Commit 87f5561

Browse files
ggreenmalucacoelho
authored andcommitted
iwlwifi: mvm: rs: fix TLC statistics collection
Statistics should be collected according to the actual rate a frame/aggregation was transmitted and not according to the initial rate from the last LQ command (these rates are different if the frames were retransmitted at a lower rate from the rate scale table). This is needed to remove throughput degradation. Signed-off-by: Gregory Greenman <[email protected]> Signed-off-by: Luca Coelho <[email protected]>
1 parent 9465c3f commit 87f5561

File tree

1 file changed

+4
-4
lines changed
  • drivers/net/wireless/intel/iwlwifi/mvm

1 file changed

+4
-4
lines changed

drivers/net/wireless/intel/iwlwifi/mvm/rs.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1291,7 +1291,7 @@ void iwl_mvm_rs_tx_status(struct iwl_mvm *mvm, struct ieee80211_sta *sta,
12911291
* first index into rate scale table.
12921292
*/
12931293
if (info->flags & IEEE80211_TX_STAT_AMPDU) {
1294-
rs_collect_tpc_data(mvm, lq_sta, curr_tbl, lq_rate.index,
1294+
rs_collect_tpc_data(mvm, lq_sta, curr_tbl, tx_resp_rate.index,
12951295
info->status.ampdu_len,
12961296
info->status.ampdu_ack_len,
12971297
reduced_txp);
@@ -1312,7 +1312,7 @@ void iwl_mvm_rs_tx_status(struct iwl_mvm *mvm, struct ieee80211_sta *sta,
13121312
if (info->status.ampdu_ack_len == 0)
13131313
info->status.ampdu_len = 1;
13141314

1315-
rs_collect_tlc_data(mvm, lq_sta, curr_tbl, lq_rate.index,
1315+
rs_collect_tlc_data(mvm, lq_sta, curr_tbl, tx_resp_rate.index,
13161316
info->status.ampdu_len,
13171317
info->status.ampdu_ack_len);
13181318

@@ -1348,11 +1348,11 @@ void iwl_mvm_rs_tx_status(struct iwl_mvm *mvm, struct ieee80211_sta *sta,
13481348
continue;
13491349

13501350
rs_collect_tpc_data(mvm, lq_sta, tmp_tbl,
1351-
lq_rate.index, 1,
1351+
tx_resp_rate.index, 1,
13521352
i < retries ? 0 : legacy_success,
13531353
reduced_txp);
13541354
rs_collect_tlc_data(mvm, lq_sta, tmp_tbl,
1355-
lq_rate.index, 1,
1355+
tx_resp_rate.index, 1,
13561356
i < retries ? 0 : legacy_success);
13571357
}
13581358

0 commit comments

Comments
 (0)