Skip to content

Commit 7cad1ba

Browse files
David Decotignydavem330
authored andcommitted
net: core: use __ethtool_get_ksettings
Signed-off-by: David Decotigny <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 702b26a commit 7cad1ba

File tree

2 files changed

+14
-12
lines changed

2 files changed

+14
-12
lines changed

net/core/net-sysfs.c

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -198,9 +198,10 @@ static ssize_t speed_show(struct device *dev,
198198
return restart_syscall();
199199

200200
if (netif_running(netdev)) {
201-
struct ethtool_cmd cmd;
202-
if (!__ethtool_get_settings(netdev, &cmd))
203-
ret = sprintf(buf, fmt_dec, ethtool_cmd_speed(&cmd));
201+
struct ethtool_link_ksettings cmd;
202+
203+
if (!__ethtool_get_link_ksettings(netdev, &cmd))
204+
ret = sprintf(buf, fmt_dec, cmd.base.speed);
204205
}
205206
rtnl_unlock();
206207
return ret;
@@ -217,10 +218,12 @@ static ssize_t duplex_show(struct device *dev,
217218
return restart_syscall();
218219

219220
if (netif_running(netdev)) {
220-
struct ethtool_cmd cmd;
221-
if (!__ethtool_get_settings(netdev, &cmd)) {
221+
struct ethtool_link_ksettings cmd;
222+
223+
if (!__ethtool_get_link_ksettings(netdev, &cmd)) {
222224
const char *duplex;
223-
switch (cmd.duplex) {
225+
226+
switch (cmd.base.duplex) {
224227
case DUPLEX_HALF:
225228
duplex = "half";
226229
break;

net/packet/af_packet.c

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -557,29 +557,28 @@ static int prb_calc_retire_blk_tmo(struct packet_sock *po,
557557
{
558558
struct net_device *dev;
559559
unsigned int mbits = 0, msec = 0, div = 0, tmo = 0;
560-
struct ethtool_cmd ecmd;
560+
struct ethtool_link_ksettings ecmd;
561561
int err;
562-
u32 speed;
563562

564563
rtnl_lock();
565564
dev = __dev_get_by_index(sock_net(&po->sk), po->ifindex);
566565
if (unlikely(!dev)) {
567566
rtnl_unlock();
568567
return DEFAULT_PRB_RETIRE_TOV;
569568
}
570-
err = __ethtool_get_settings(dev, &ecmd);
571-
speed = ethtool_cmd_speed(&ecmd);
569+
err = __ethtool_get_link_ksettings(dev, &ecmd);
572570
rtnl_unlock();
573571
if (!err) {
574572
/*
575573
* If the link speed is so slow you don't really
576574
* need to worry about perf anyways
577575
*/
578-
if (speed < SPEED_1000 || speed == SPEED_UNKNOWN) {
576+
if (ecmd.base.speed < SPEED_1000 ||
577+
ecmd.base.speed == SPEED_UNKNOWN) {
579578
return DEFAULT_PRB_RETIRE_TOV;
580579
} else {
581580
msec = 1;
582-
div = speed / 1000;
581+
div = ecmd.base.speed / 1000;
583582
}
584583
}
585584

0 commit comments

Comments
 (0)