Skip to content

Commit 7bd42fb

Browse files
Wayne Changgregkh
authored andcommitted
usb: gadget: tegra-xudc: Fix control endpoint's definitions
According to the Tegra Technical Reference Manual, the seq_num field of control endpoint is not [31:24] but [31:27]. Bit 24 is reserved and bit 26 is splitxstate. The change fixes the wrong control endpoint's definitions. Signed-off-by: Wayne Chang <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent d6dd18e commit 7bd42fb

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

drivers/usb/gadget/udc/tegra-xudc.c

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -272,8 +272,10 @@ BUILD_EP_CONTEXT_RW(deq_hi, deq_hi, 0, 0xffffffff)
272272
BUILD_EP_CONTEXT_RW(avg_trb_len, tx_info, 0, 0xffff)
273273
BUILD_EP_CONTEXT_RW(max_esit_payload, tx_info, 16, 0xffff)
274274
BUILD_EP_CONTEXT_RW(edtla, rsvd[0], 0, 0xffffff)
275-
BUILD_EP_CONTEXT_RW(seq_num, rsvd[0], 24, 0xff)
275+
BUILD_EP_CONTEXT_RW(rsvd, rsvd[0], 24, 0x1)
276276
BUILD_EP_CONTEXT_RW(partial_td, rsvd[0], 25, 0x1)
277+
BUILD_EP_CONTEXT_RW(splitxstate, rsvd[0], 26, 0x1)
278+
BUILD_EP_CONTEXT_RW(seq_num, rsvd[0], 27, 0x1f)
277279
BUILD_EP_CONTEXT_RW(cerrcnt, rsvd[1], 18, 0x3)
278280
BUILD_EP_CONTEXT_RW(data_offset, rsvd[2], 0, 0x1ffff)
279281
BUILD_EP_CONTEXT_RW(numtrbs, rsvd[2], 22, 0x1f)
@@ -1554,6 +1556,9 @@ static int __tegra_xudc_ep_set_halt(struct tegra_xudc_ep *ep, bool halt)
15541556
ep_reload(xudc, ep->index);
15551557

15561558
ep_ctx_write_state(ep->context, EP_STATE_RUNNING);
1559+
ep_ctx_write_rsvd(ep->context, 0);
1560+
ep_ctx_write_partial_td(ep->context, 0);
1561+
ep_ctx_write_splitxstate(ep->context, 0);
15571562
ep_ctx_write_seq_num(ep->context, 0);
15581563

15591564
ep_reload(xudc, ep->index);
@@ -2809,7 +2814,10 @@ static void tegra_xudc_reset(struct tegra_xudc *xudc)
28092814
xudc->setup_seq_num = 0;
28102815
xudc->queued_setup_packet = false;
28112816

2812-
ep_ctx_write_seq_num(ep0->context, xudc->setup_seq_num);
2817+
ep_ctx_write_rsvd(ep0->context, 0);
2818+
ep_ctx_write_partial_td(ep0->context, 0);
2819+
ep_ctx_write_splitxstate(ep0->context, 0);
2820+
ep_ctx_write_seq_num(ep0->context, 0);
28132821

28142822
deq_ptr = trb_virt_to_phys(ep0, &ep0->transfer_ring[ep0->deq_ptr]);
28152823

0 commit comments

Comments
 (0)