Skip to content

Commit 74a3bc4

Browse files
Wan Jiabingdavem330
authored andcommitted
net: mscc: ocelot: Fix dumplicated argument in ocelot
Fix the following coccicheck warning: drivers/net/ethernet/mscc/ocelot.c:474:duplicated argument to & or | drivers/net/ethernet/mscc/ocelot.c:476:duplicated argument to & or | drivers/net/ethernet/mscc/ocelot_net.c:1627:duplicated argument to & or | These DEV_CLOCK_CFG_MAC_TX_RST are duplicate here. Here should be DEV_CLOCK_CFG_MAC_RX_RST. Fixes: e6e12df ("net: mscc: ocelot: convert to phylink") Signed-off-by: Wan Jiabing <[email protected]> Reviewed-by: Vladimir Oltean <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 0edf082 commit 74a3bc4

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

drivers/net/ethernet/mscc/ocelot.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -472,9 +472,9 @@ void ocelot_phylink_mac_link_down(struct ocelot *ocelot, int port,
472472
!(quirks & OCELOT_QUIRK_QSGMII_PORTS_MUST_BE_UP))
473473
ocelot_port_rmwl(ocelot_port,
474474
DEV_CLOCK_CFG_MAC_TX_RST |
475-
DEV_CLOCK_CFG_MAC_TX_RST,
475+
DEV_CLOCK_CFG_MAC_RX_RST,
476476
DEV_CLOCK_CFG_MAC_TX_RST |
477-
DEV_CLOCK_CFG_MAC_TX_RST,
477+
DEV_CLOCK_CFG_MAC_RX_RST,
478478
DEV_CLOCK_CFG);
479479
}
480480
EXPORT_SYMBOL_GPL(ocelot_phylink_mac_link_down);

drivers/net/ethernet/mscc/ocelot_net.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1625,7 +1625,7 @@ static int ocelot_port_phylink_create(struct ocelot *ocelot, int port,
16251625
if (phy_mode == PHY_INTERFACE_MODE_QSGMII)
16261626
ocelot_port_rmwl(ocelot_port, 0,
16271627
DEV_CLOCK_CFG_MAC_TX_RST |
1628-
DEV_CLOCK_CFG_MAC_TX_RST,
1628+
DEV_CLOCK_CFG_MAC_RX_RST,
16291629
DEV_CLOCK_CFG);
16301630

16311631
ocelot_port->phy_mode = phy_mode;

0 commit comments

Comments
 (0)