Skip to content

Commit 73edcd3

Browse files
mkshahcandersson
authored andcommitted
soc: qcom: rpmh: Update rpmh_invalidate function to return void
Currently rpmh_invalidate() always returns success. Update its return type to void. Reviewed-by: Lina Iyer <[email protected]> Reviewed-by: Stephen Boyd <[email protected]> Suggested-by: Stephen Boyd <[email protected]> Signed-off-by: Maulik Shah <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Bjorn Andersson <[email protected]>
1 parent 681b091 commit 73edcd3

File tree

3 files changed

+6
-11
lines changed

3 files changed

+6
-11
lines changed

drivers/interconnect/qcom/bcm-voter.c

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -266,11 +266,7 @@ int qcom_icc_bcm_voter_commit(struct bcm_voter *voter)
266266
if (!commit_idx[0])
267267
goto out;
268268

269-
ret = rpmh_invalidate(voter->dev);
270-
if (ret) {
271-
pr_err("Error invalidating RPMH client (%d)\n", ret);
272-
goto out;
273-
}
269+
rpmh_invalidate(voter->dev);
274270

275271
ret = rpmh_write_batch(voter->dev, RPMH_ACTIVE_ONLY_STATE,
276272
cmds, commit_idx);

drivers/soc/qcom/rpmh.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -497,7 +497,7 @@ int rpmh_flush(struct rpmh_ctrlr *ctrlr)
497497
*
498498
* Invalidate the sleep and wake values in batch_cache.
499499
*/
500-
int rpmh_invalidate(const struct device *dev)
500+
void rpmh_invalidate(const struct device *dev)
501501
{
502502
struct rpmh_ctrlr *ctrlr = get_rpmh_ctrlr(dev);
503503
struct batch_cache_req *req, *tmp;
@@ -509,7 +509,5 @@ int rpmh_invalidate(const struct device *dev)
509509
INIT_LIST_HEAD(&ctrlr->batch_cache);
510510
ctrlr->dirty = true;
511511
spin_unlock_irqrestore(&ctrlr->cache_lock, flags);
512-
513-
return 0;
514512
}
515513
EXPORT_SYMBOL(rpmh_invalidate);

include/soc/qcom/rpmh.h

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ int rpmh_write_async(const struct device *dev, enum rpmh_state state,
2020
int rpmh_write_batch(const struct device *dev, enum rpmh_state state,
2121
const struct tcs_cmd *cmd, u32 *n);
2222

23-
int rpmh_invalidate(const struct device *dev);
23+
void rpmh_invalidate(const struct device *dev);
2424

2525
#else
2626

@@ -38,8 +38,9 @@ static inline int rpmh_write_batch(const struct device *dev,
3838
const struct tcs_cmd *cmd, u32 *n)
3939
{ return -ENODEV; }
4040

41-
static inline int rpmh_invalidate(const struct device *dev)
42-
{ return -ENODEV; }
41+
static inline void rpmh_invalidate(const struct device *dev)
42+
{
43+
}
4344

4445
#endif /* CONFIG_QCOM_RPMH */
4546

0 commit comments

Comments
 (0)