NFS: use sysfs_emit() to instead of scnprintf()

ye xingchen · Trond Myklebust · commit 700fa9b1b361 · 2022-12-06T12:32:37.000-05:00
Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: ye xingchen &lt;ye.xingchen@zte.com.cn&gt;
Signed-off-by: Trond Myklebust &lt;trond.myklebust@hammerspace.com&gt;
diff --git a/fs/nfs/namespace.c b/fs/nfs/namespace.c
@@ -354,7 +354,7 @@ static int param_get_nfs_timeout(char *buffer, const struct kernel_param *kp)
 			num = (num + (HZ - 1)) / HZ;
 	} else
 		num = -1;
-	return scnprintf(buffer, PAGE_SIZE, "%li\n", num);
+	return sysfs_emit(buffer, "%li\n", num);
 }
 
 static const struct kernel_param_ops param_ops_nfs_timeout = {

Original file line number	Diff line number	Diff line change
`@@ -354,7 +354,7 @@ static int param_get_nfs_timeout(char buffer, const struct kernel_param kp)`
`354`	`354`	`num = (num + (HZ - 1)) / HZ;`
`355`	`355`	`} else`
`356`	`356`	`num = -1;`
`357`		`- return scnprintf(buffer, PAGE_SIZE, "%li\n", num);`
	`357`	`+ return sysfs_emit(buffer, "%li\n", num);`
`358`	`358`	`}`
`359`	`359`
`360`	`360`	`static const struct kernel_param_ops param_ops_nfs_timeout = {`