Skip to content

Commit 6e30c54

Browse files
Sebastian OttMartin Schwidefsky
authored andcommitted
s390/qdio: remove checks for ccw device internal state
Prior to starting IO qdio checks for the internal state of the ccw device. These checks happen without locking, so consistency between state evaluation and starting of the IO is not guaranteed. Since the internal state is checked during ccw_device_start it is safe to get rid of these additional checks. Signed-off-by: Sebastian Ott <[email protected]> Reviewed-by: Cornelia Huck <[email protected]> Signed-off-by: Martin Schwidefsky <[email protected]>
1 parent ddebf66 commit 6e30c54

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

drivers/s390/cio/qdio_main.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1352,9 +1352,6 @@ int qdio_establish(struct qdio_initialize *init_data)
13521352
if (!irq_ptr)
13531353
return -ENODEV;
13541354

1355-
if (cdev->private->state != DEV_STATE_ONLINE)
1356-
return -EINVAL;
1357-
13581355
mutex_lock(&irq_ptr->setup_mutex);
13591356
qdio_setup_irq(init_data);
13601357

@@ -1425,9 +1422,6 @@ int qdio_activate(struct ccw_device *cdev)
14251422
if (!irq_ptr)
14261423
return -ENODEV;
14271424

1428-
if (cdev->private->state != DEV_STATE_ONLINE)
1429-
return -EINVAL;
1430-
14311425
mutex_lock(&irq_ptr->setup_mutex);
14321426
if (irq_ptr->state == QDIO_IRQ_STATE_INACTIVE) {
14331427
rc = -EBUSY;

0 commit comments

Comments
 (0)