Skip to content

Commit 6a1dbfe

Browse files
geertukuba-moo
authored andcommitted
net: sh_eth: Fix PHY state warning splat during system resume
Since commit 744d23c ("net: phy: Warn about incorrect mdio_bus_phy_resume() state"), a warning splat is printed during system resume with Wake-on-LAN disabled: WARNING: CPU: 0 PID: 626 at drivers/net/phy/phy_device.c:323 mdio_bus_phy_resume+0xbc/0xe4 As the Renesas SuperH Ethernet driver already calls phy_{stop,start}() in its suspend/resume callbacks, it is sufficient to just mark the MAC responsible for managing the power state of the PHY. Fixes: fba863b ("net: phy: make PHY PM ops a no-op if MAC driver manages PHY PM") Signed-off-by: Geert Uytterhoeven <[email protected]> Reviewed-by: Florian Fainelli <[email protected]> Reviewed-by: Sergey Shtylyov <[email protected]> Link: https://lore.kernel.org/r/c6e1331b9bef61225fa4c09db3ba3e2e7214ba2d.1663598886.git.geert+renesas@glider.be Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 4924c0c commit 6a1dbfe

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/net/ethernet/renesas/sh_eth.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2029,6 +2029,8 @@ static int sh_eth_phy_init(struct net_device *ndev)
20292029
if (mdp->cd->register_type != SH_ETH_REG_GIGABIT)
20302030
phy_set_max_speed(phydev, SPEED_100);
20312031

2032+
/* Indicate that the MAC is responsible for managing PHY PM */
2033+
phydev->mac_managed_pm = true;
20322034
phy_attached_info(phydev);
20332035

20342036
return 0;

0 commit comments

Comments
 (0)