Skip to content

Commit 68cc977

Browse files
labbottsashalevin
authored andcommitted
dma-debug: switch check from _text to _stext
[ Upstream commit ea535e4 ] In include/asm-generic/sections.h: /* * Usage guidelines: * _text, _data: architecture specific, don't use them in * arch-independent code * [_stext, _etext]: contains .text.* sections, may also contain * .rodata.* * and/or .init.* sections _text is not guaranteed across architectures. Architectures such as ARM may reuse parts which are not actually text and erroneously trigger a bug. Switch to using _stext which is guaranteed to contain text sections. Came out of https://lkml.kernel.org/g/<[email protected]> Signed-off-by: Laura Abbott <[email protected]> Reviewed-by: Kees Cook <[email protected]> Cc: Russell King <[email protected]> Cc: Arnd Bergmann <[email protected]> Cc: <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]> Signed-off-by: Sasha Levin <[email protected]>
1 parent a5254ac commit 68cc977

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lib/dma-debug.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1181,7 +1181,7 @@ static inline bool overlap(void *addr, unsigned long len, void *start, void *end
11811181

11821182
static void check_for_illegal_area(struct device *dev, void *addr, unsigned long len)
11831183
{
1184-
if (overlap(addr, len, _text, _etext) ||
1184+
if (overlap(addr, len, _stext, _etext) ||
11851185
overlap(addr, len, __start_rodata, __end_rodata))
11861186
err_printk(dev, NULL, "DMA-API: device driver maps memory from kernel text or rodata [addr=%p] [len=%lu]\n", addr, len);
11871187
}

0 commit comments

Comments
 (0)