Skip to content

Commit 685489a

Browse files
committed
platform/x86: thinkpad_acpi: Do not report SW_TABLET_MODE on Yoga 11e
The Yoga 11e series has 2 accelerometers described by a BOSC0200 ACPI node. This setup relies on a Windows service which reads both accelerometers and then calculates the angle between the 2 halves to determine laptop / tent / tablet mode and then reports the calculated mode back to the EC by calling special ACPI methods on the BOSC0200 node. The bmc150 iio driver does not support this (it involves double calculations requiring sqrt and arccos so this really needs to be done in userspace), as a result of this on the Yoga 11e the thinkpad_acpi code always reports SW_TABLET_MODE=0, starting with GNOME 3.38 reporting SW_TABLET_MODE=0 causes GNOME to: 1. Not show the onscreen keyboard when a text-input field is focussed with the touchscreen. 2. Disable accelerometer based auto display-rotation. This makes sense when in laptop-mode but not when in tablet-mode. But since for the Yoga 11e the thinkpad_acpi code always reports SW_TABLET_MODE=0, GNOME does not know when the device is in tablet-mode. Stop reporting the broken (always 0) SW_TABLET_MODE on Yoga 11e models to fix this. Note there are plans for userspace to support 360 degree hinges style 2-in-1s with 2 accelerometers and figure out the mode by itself, see: https://gitlab.freedesktop.org/hadess/iio-sensor-proxy/-/issues/216 Signed-off-by: Hans de Goede <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent c758be8 commit 685489a

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

drivers/platform/x86/thinkpad_acpi.c

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3218,7 +3218,14 @@ static int hotkey_init_tablet_mode(void)
32183218

32193219
in_tablet_mode = hotkey_gmms_get_tablet_mode(res,
32203220
&has_tablet_mode);
3221-
if (has_tablet_mode)
3221+
/*
3222+
* The Yoga 11e series has 2 accelerometers described by a
3223+
* BOSC0200 ACPI node. This setup relies on a Windows service
3224+
* which calls special ACPI methods on this node to report
3225+
* the laptop/tent/tablet mode to the EC. The bmc150 iio driver
3226+
* does not support this, so skip the hotkey on these models.
3227+
*/
3228+
if (has_tablet_mode && !acpi_dev_present("BOSC0200", "1", -1))
32223229
tp_features.hotkey_tablet = TP_HOTKEY_TABLET_USES_GMMS;
32233230
type = "GMMS";
32243231
} else if (acpi_evalf(hkey_handle, &res, "MHKG", "qd")) {

0 commit comments

Comments
 (0)