Skip to content

Commit 624aea6

Browse files
committed
Merge branch '100GbE' of git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue
Tony Nguyen says: ==================== Intel Wired LAN Driver Updates 2022-09-20 (ice) Michal re-sets TC configuration when changing number of queues. Mateusz moves the check and call for link-down-on-close to the specific path for downing/closing the interface. * '100GbE' of git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue: ice: Fix interface being down after reset with link-down-on-close flag on ice: config netdev tc before setting queues number ==================== Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
2 parents 114f398 + 8ac7132 commit 624aea6

File tree

1 file changed

+14
-9
lines changed

1 file changed

+14
-9
lines changed

drivers/net/ethernet/intel/ice/ice_main.c

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6649,7 +6649,7 @@ static void ice_napi_disable_all(struct ice_vsi *vsi)
66496649
*/
66506650
int ice_down(struct ice_vsi *vsi)
66516651
{
6652-
int i, tx_err, rx_err, link_err = 0, vlan_err = 0;
6652+
int i, tx_err, rx_err, vlan_err = 0;
66536653

66546654
WARN_ON(!test_bit(ICE_VSI_DOWN, vsi->state));
66556655

@@ -6683,20 +6683,13 @@ int ice_down(struct ice_vsi *vsi)
66836683

66846684
ice_napi_disable_all(vsi);
66856685

6686-
if (test_bit(ICE_FLAG_LINK_DOWN_ON_CLOSE_ENA, vsi->back->flags)) {
6687-
link_err = ice_force_phys_link_state(vsi, false);
6688-
if (link_err)
6689-
netdev_err(vsi->netdev, "Failed to set physical link down, VSI %d error %d\n",
6690-
vsi->vsi_num, link_err);
6691-
}
6692-
66936686
ice_for_each_txq(vsi, i)
66946687
ice_clean_tx_ring(vsi->tx_rings[i]);
66956688

66966689
ice_for_each_rxq(vsi, i)
66976690
ice_clean_rx_ring(vsi->rx_rings[i]);
66986691

6699-
if (tx_err || rx_err || link_err || vlan_err) {
6692+
if (tx_err || rx_err || vlan_err) {
67006693
netdev_err(vsi->netdev, "Failed to close VSI 0x%04X on switch 0x%04X\n",
67016694
vsi->vsi_num, vsi->vsw->sw_id);
67026695
return -EIO;
@@ -6858,6 +6851,8 @@ int ice_vsi_open(struct ice_vsi *vsi)
68586851
if (err)
68596852
goto err_setup_rx;
68606853

6854+
ice_vsi_cfg_netdev_tc(vsi, vsi->tc_cfg.ena_tc);
6855+
68616856
if (vsi->type == ICE_VSI_PF) {
68626857
/* Notify the stack of the actual queue counts. */
68636858
err = netif_set_real_num_tx_queues(vsi->netdev, vsi->num_txq);
@@ -8890,6 +8885,16 @@ int ice_stop(struct net_device *netdev)
88908885
return -EBUSY;
88918886
}
88928887

8888+
if (test_bit(ICE_FLAG_LINK_DOWN_ON_CLOSE_ENA, vsi->back->flags)) {
8889+
int link_err = ice_force_phys_link_state(vsi, false);
8890+
8891+
if (link_err) {
8892+
netdev_err(vsi->netdev, "Failed to set physical link down, VSI %d error %d\n",
8893+
vsi->vsi_num, link_err);
8894+
return -EIO;
8895+
}
8896+
}
8897+
88938898
ice_vsi_close(vsi);
88948899

88958900
return 0;

0 commit comments

Comments
 (0)