Skip to content

Commit 609c130

Browse files
tititiou36davem330
authored andcommitted
hinic: switch from 'pci_' to 'dma_' API
The wrappers in include/linux/pci-dma-compat.h should go away. The patch has been generated with the coccinelle script below. It has been hand modified to use 'dma_set_mask_and_coherent()' instead of 'pci_set_dma_mask()/pci_set_consistent_dma_mask()' when applicable. This is less verbose. It has been compile tested. @@ @@ - PCI_DMA_BIDIRECTIONAL + DMA_BIDIRECTIONAL @@ @@ - PCI_DMA_TODEVICE + DMA_TO_DEVICE @@ @@ - PCI_DMA_FROMDEVICE + DMA_FROM_DEVICE @@ @@ - PCI_DMA_NONE + DMA_NONE @@ expression e1, e2, e3; @@ - pci_alloc_consistent(e1, e2, e3) + dma_alloc_coherent(&e1->dev, e2, e3, GFP_) @@ expression e1, e2, e3; @@ - pci_zalloc_consistent(e1, e2, e3) + dma_alloc_coherent(&e1->dev, e2, e3, GFP_) @@ expression e1, e2, e3, e4; @@ - pci_free_consistent(e1, e2, e3, e4) + dma_free_coherent(&e1->dev, e2, e3, e4) @@ expression e1, e2, e3, e4; @@ - pci_map_single(e1, e2, e3, e4) + dma_map_single(&e1->dev, e2, e3, e4) @@ expression e1, e2, e3, e4; @@ - pci_unmap_single(e1, e2, e3, e4) + dma_unmap_single(&e1->dev, e2, e3, e4) @@ expression e1, e2, e3, e4, e5; @@ - pci_map_page(e1, e2, e3, e4, e5) + dma_map_page(&e1->dev, e2, e3, e4, e5) @@ expression e1, e2, e3, e4; @@ - pci_unmap_page(e1, e2, e3, e4) + dma_unmap_page(&e1->dev, e2, e3, e4) @@ expression e1, e2, e3, e4; @@ - pci_map_sg(e1, e2, e3, e4) + dma_map_sg(&e1->dev, e2, e3, e4) @@ expression e1, e2, e3, e4; @@ - pci_unmap_sg(e1, e2, e3, e4) + dma_unmap_sg(&e1->dev, e2, e3, e4) @@ expression e1, e2, e3, e4; @@ - pci_dma_sync_single_for_cpu(e1, e2, e3, e4) + dma_sync_single_for_cpu(&e1->dev, e2, e3, e4) @@ expression e1, e2, e3, e4; @@ - pci_dma_sync_single_for_device(e1, e2, e3, e4) + dma_sync_single_for_device(&e1->dev, e2, e3, e4) @@ expression e1, e2, e3, e4; @@ - pci_dma_sync_sg_for_cpu(e1, e2, e3, e4) + dma_sync_sg_for_cpu(&e1->dev, e2, e3, e4) @@ expression e1, e2, e3, e4; @@ - pci_dma_sync_sg_for_device(e1, e2, e3, e4) + dma_sync_sg_for_device(&e1->dev, e2, e3, e4) @@ expression e1, e2; @@ - pci_dma_mapping_error(e1, e2) + dma_mapping_error(&e1->dev, e2) @@ expression e1, e2; @@ - pci_set_dma_mask(e1, e2) + dma_set_mask(&e1->dev, e2) @@ expression e1, e2; @@ - pci_set_consistent_dma_mask(e1, e2) + dma_set_coherent_mask(&e1->dev, e2) Signed-off-by: Christophe JAILLET <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent a14e390 commit 609c130

File tree

1 file changed

+2
-15
lines changed

1 file changed

+2
-15
lines changed

drivers/net/ethernet/huawei/hinic/hinic_main.c

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1392,28 +1392,16 @@ static int hinic_probe(struct pci_dev *pdev,
13921392

13931393
pci_set_master(pdev);
13941394

1395-
err = pci_set_dma_mask(pdev, DMA_BIT_MASK(64));
1395+
err = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
13961396
if (err) {
13971397
dev_warn(&pdev->dev, "Couldn't set 64-bit DMA mask\n");
1398-
err = pci_set_dma_mask(pdev, DMA_BIT_MASK(32));
1398+
err = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
13991399
if (err) {
14001400
dev_err(&pdev->dev, "Failed to set DMA mask\n");
14011401
goto err_dma_mask;
14021402
}
14031403
}
14041404

1405-
err = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(64));
1406-
if (err) {
1407-
dev_warn(&pdev->dev,
1408-
"Couldn't set 64-bit consistent DMA mask\n");
1409-
err = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32));
1410-
if (err) {
1411-
dev_err(&pdev->dev,
1412-
"Failed to set consistent DMA mask\n");
1413-
goto err_dma_consistent_mask;
1414-
}
1415-
}
1416-
14171405
err = nic_dev_init(pdev);
14181406
if (err) {
14191407
dev_err(&pdev->dev, "Failed to initialize NIC device\n");
@@ -1424,7 +1412,6 @@ static int hinic_probe(struct pci_dev *pdev,
14241412
return 0;
14251413

14261414
err_nic_dev_init:
1427-
err_dma_consistent_mask:
14281415
err_dma_mask:
14291416
pci_release_regions(pdev);
14301417

0 commit comments

Comments
 (0)