Skip to content

Commit 5f5d031

Browse files
Arend Van SprielKalle Valo
authored andcommitted
brcmfmac: fix memleak due to calling brcmf_sdiod_sgtable_alloc() twice
Due to a bugfix in wireless tree and the commit mentioned below a merge was needed which went haywire. So the submitted change resulted in the function brcmf_sdiod_sgtable_alloc() being called twice during the probe thus leaking the memory of the first call. Cc: [email protected] # 4.6.x Fixes: 4d79289 ("brcmfmac: switch to new platform data") Reported-by: Stefan Wahren <[email protected]> Tested-by: Stefan Wahren <[email protected]> Reviewed-by: Hante Meuleman <[email protected]> Signed-off-by: Arend van Spriel <[email protected]> Signed-off-by: Kalle Valo <[email protected]>
1 parent 58f36b4 commit 5f5d031

File tree

1 file changed

+0
-5
lines changed
  • drivers/net/wireless/broadcom/brcm80211/brcmfmac

1 file changed

+0
-5
lines changed

drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4175,11 +4175,6 @@ struct brcmf_sdio *brcmf_sdio_probe(struct brcmf_sdio_dev *sdiodev)
41754175
goto fail;
41764176
}
41774177

4178-
/* allocate scatter-gather table. sg support
4179-
* will be disabled upon allocation failure.
4180-
*/
4181-
brcmf_sdiod_sgtable_alloc(bus->sdiodev);
4182-
41834178
/* Query the F2 block size, set roundup accordingly */
41844179
bus->blocksize = bus->sdiodev->func[2]->cur_blksize;
41854180
bus->roundup = min(max_roundup, bus->blocksize);

0 commit comments

Comments
 (0)