Skip to content

Commit 5d545a7

Browse files
jdelvaresashalevin
authored andcommitted
crypto: crc32c - Fix crc32c soft dependency
[ Upstream commit fd7f672 ] I don't think it makes sense for a module to have a soft dependency on itself. This seems quite cyclic by nature and I can't see what purpose it could serve. OTOH libcrc32c calls crypto_alloc_shash("crc32c", 0, 0) so it pretty much assumes that some incarnation of the "crc32c" hash algorithm has been loaded. Therefore it makes sense to have the soft dependency there (as crc-t10dif does.) Cc: [email protected] Cc: Tim Chen <[email protected]> Cc: "David S. Miller" <[email protected]> Signed-off-by: Jean Delvare <[email protected]> Signed-off-by: Herbert Xu <[email protected]> Signed-off-by: Sasha Levin <[email protected]>
1 parent 4126014 commit 5d545a7

File tree

2 files changed

+1
-1
lines changed

2 files changed

+1
-1
lines changed

crypto/crc32c_generic.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,4 +172,3 @@ MODULE_DESCRIPTION("CRC32c (Castagnoli) calculations wrapper for lib/crc32c");
172172
MODULE_LICENSE("GPL");
173173
MODULE_ALIAS_CRYPTO("crc32c");
174174
MODULE_ALIAS_CRYPTO("crc32c-generic");
175-
MODULE_SOFTDEP("pre: crc32c");

lib/libcrc32c.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,3 +74,4 @@ module_exit(libcrc32c_mod_fini);
7474
MODULE_AUTHOR("Clay Haapala <[email protected]>");
7575
MODULE_DESCRIPTION("CRC32c (Castagnoli) calculations");
7676
MODULE_LICENSE("GPL");
77+
MODULE_SOFTDEP("pre: crc32c");

0 commit comments

Comments
 (0)