Skip to content

Commit 5cb6c6c

Browse files
author
Al Viro
committed
generic_file_direct_write(): get rid of ppos argument
always equal to &iocb->ki_pos. Signed-off-by: Al Viro <[email protected]>
1 parent 867c4f9 commit 5cb6c6c

File tree

6 files changed

+8
-9
lines changed

6 files changed

+8
-9
lines changed

fs/btrfs/file.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1640,7 +1640,7 @@ static ssize_t __btrfs_direct_write(struct kiocb *iocb,
16401640
loff_t endbyte;
16411641
int err;
16421642

1643-
written = generic_file_direct_write(iocb, iov, &nr_segs, pos, &iocb->ki_pos,
1643+
written = generic_file_direct_write(iocb, iov, &nr_segs, pos,
16441644
count, ocount);
16451645

16461646
if (written < 0 || written == count)

fs/fuse/file.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1143,8 +1143,7 @@ static ssize_t fuse_file_aio_write(struct kiocb *iocb, const struct iovec *iov,
11431143
goto out;
11441144

11451145
if (file->f_flags & O_DIRECT) {
1146-
written = generic_file_direct_write(iocb, iov, &nr_segs,
1147-
pos, &iocb->ki_pos,
1146+
written = generic_file_direct_write(iocb, iov, &nr_segs, pos,
11481147
count, ocount);
11491148
if (written < 0 || written == count)
11501149
goto out;

fs/ocfs2/file.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2375,7 +2375,7 @@ static ssize_t ocfs2_file_aio_write(struct kiocb *iocb,
23752375

23762376
if (direct_io) {
23772377
written = generic_file_direct_write(iocb, iov, &nr_segs, *ppos,
2378-
ppos, count, ocount);
2378+
count, ocount);
23792379
if (written < 0) {
23802380
ret = written;
23812381
goto out_dio;

fs/xfs/xfs_file.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -699,7 +699,7 @@ xfs_file_dio_aio_write(
699699

700700
trace_xfs_file_direct_write(ip, count, iocb->ki_pos, 0);
701701
ret = generic_file_direct_write(iocb, iovp,
702-
&nr_segs, pos, &iocb->ki_pos, count, ocount);
702+
&nr_segs, pos, count, ocount);
703703

704704
out:
705705
xfs_rw_iunlock(ip, iolock);

include/linux/fs.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2395,7 +2395,7 @@ extern ssize_t generic_file_aio_read(struct kiocb *, const struct iovec *, unsig
23952395
extern ssize_t __generic_file_aio_write(struct kiocb *, const struct iovec *, unsigned long);
23962396
extern ssize_t generic_file_aio_write(struct kiocb *, const struct iovec *, unsigned long, loff_t);
23972397
extern ssize_t generic_file_direct_write(struct kiocb *, const struct iovec *,
2398-
unsigned long *, loff_t, loff_t *, size_t, size_t);
2398+
unsigned long *, loff_t, size_t, size_t);
23992399
extern ssize_t generic_file_buffered_write(struct kiocb *, const struct iovec *,
24002400
unsigned long, loff_t, size_t, ssize_t);
24012401
extern ssize_t do_sync_read(struct file *filp, char __user *buf, size_t len, loff_t *ppos);

mm/filemap.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1985,7 +1985,7 @@ EXPORT_SYMBOL(pagecache_write_end);
19851985

19861986
ssize_t
19871987
generic_file_direct_write(struct kiocb *iocb, const struct iovec *iov,
1988-
unsigned long *nr_segs, loff_t pos, loff_t *ppos,
1988+
unsigned long *nr_segs, loff_t pos,
19891989
size_t count, size_t ocount)
19901990
{
19911991
struct file *file = iocb->ki_filp;
@@ -2046,7 +2046,7 @@ generic_file_direct_write(struct kiocb *iocb, const struct iovec *iov,
20462046
i_size_write(inode, pos);
20472047
mark_inode_dirty(inode);
20482048
}
2049-
*ppos = pos;
2049+
iocb->ki_pos = pos;
20502050
}
20512051
out:
20522052
return written;
@@ -2265,7 +2265,7 @@ ssize_t __generic_file_aio_write(struct kiocb *iocb, const struct iovec *iov,
22652265
ssize_t written_buffered;
22662266

22672267
written = generic_file_direct_write(iocb, iov, &nr_segs, pos,
2268-
&iocb->ki_pos, count, ocount);
2268+
count, ocount);
22692269
if (written < 0 || written == count)
22702270
goto out;
22712271
/*

0 commit comments

Comments
 (0)