Skip to content

Commit 5a6bd84

Browse files
Barry Songdavem330
authored andcommitted
net: hns: use IRQ_NOAUTOEN to avoid irq is enabled due to request_irq
Rather than doing request_irq and then disabling the irq immediately, it should be safer to use IRQ_NOAUTOEN flag for the irq. It removes any gap between request_irq() and disable_irq(). Cc: Salil Mehta <[email protected]> Reviewed-by: Yunsheng Lin <[email protected]> Signed-off-by: Barry Song <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 1cf814a commit 5a6bd84

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/net/ethernet/hisilicon/hns/hns_enet.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
#include <linux/io.h>
1212
#include <linux/ip.h>
1313
#include <linux/ipv6.h>
14+
#include <linux/irq.h>
1415
#include <linux/module.h>
1516
#include <linux/phy.h>
1617
#include <linux/platform_device.h>
@@ -1290,14 +1291,14 @@ static int hns_nic_init_irq(struct hns_nic_priv *priv)
12901291

12911292
rd->ring->ring_name[RCB_RING_NAME_LEN - 1] = '\0';
12921293

1294+
irq_set_status_flags(rd->ring->irq, IRQ_NOAUTOEN);
12931295
ret = request_irq(rd->ring->irq,
12941296
hns_irq_handle, 0, rd->ring->ring_name, rd);
12951297
if (ret) {
12961298
netdev_err(priv->netdev, "request irq(%d) fail\n",
12971299
rd->ring->irq);
12981300
goto out_free_irq;
12991301
}
1300-
disable_irq(rd->ring->irq);
13011302

13021303
cpu = hns_nic_init_affinity_mask(h->q_num, i,
13031304
rd->ring, &rd->mask);

0 commit comments

Comments
 (0)