Skip to content

Commit 4cea877

Browse files
committed
Merge tag 'pci-v4.8-fixes-2' of git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci
Pull PCI fixes from Bjorn Helgaas: "Here are two changes for v4.8. The first fixes a "[Firmware Bug]: reg 0x10: invalid BAR (can't size)" warning on Haswell, and the second fixes a problem in some new runtime suspend functionality we merged for v4.8. Summary: Enumeration: Mark Haswell Power Control Unit as having non-compliant BARs (Bjorn Helgaas) Power management: Fix bridge_d3 update on device removal (Lukas Wunner)" * tag 'pci-v4.8-fixes-2' of git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci: PCI: Fix bridge_d3 update on device removal PCI: Mark Haswell Power Control Unit as having non-compliant BARs
2 parents 77e5bdf + 035ee28 commit 4cea877

File tree

2 files changed

+14
-9
lines changed

2 files changed

+14
-9
lines changed

arch/x86/pci/fixup.c

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -553,15 +553,21 @@ static void twinhead_reserve_killing_zone(struct pci_dev *dev)
553553
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x27B9, twinhead_reserve_killing_zone);
554554

555555
/*
556-
* Broadwell EP Home Agent BARs erroneously return non-zero values when read.
556+
* Device [8086:2fc0]
557+
* Erratum HSE43
558+
* CONFIG_TDP_NOMINAL CSR Implemented at Incorrect Offset
559+
* http://www.intel.com/content/www/us/en/processors/xeon/xeon-e5-v3-spec-update.html
557560
*
558-
* See http://www.intel.com/content/www/us/en/processors/xeon/xeon-e5-v4-spec-update.html
559-
* entry BDF2.
561+
* Devices [8086:6f60,6fa0,6fc0]
562+
* Erratum BDF2
563+
* PCI BARs in the Home Agent Will Return Non-Zero Values During Enumeration
564+
* http://www.intel.com/content/www/us/en/processors/xeon/xeon-e5-v4-spec-update.html
560565
*/
561-
static void pci_bdwep_bar(struct pci_dev *dev)
566+
static void pci_invalid_bar(struct pci_dev *dev)
562567
{
563568
dev->non_compliant_bars = 1;
564569
}
565-
DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x6f60, pci_bdwep_bar);
566-
DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x6fa0, pci_bdwep_bar);
567-
DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x6fc0, pci_bdwep_bar);
570+
DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x2fc0, pci_invalid_bar);
571+
DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x6f60, pci_invalid_bar);
572+
DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x6fa0, pci_invalid_bar);
573+
DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x6fc0, pci_invalid_bar);

drivers/pci/remove.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ static void pci_destroy_dev(struct pci_dev *dev)
4040
list_del(&dev->bus_list);
4141
up_write(&pci_bus_sem);
4242

43+
pci_bridge_d3_device_removed(dev);
4344
pci_free_resources(dev);
4445
put_device(&dev->dev);
4546
}
@@ -96,8 +97,6 @@ static void pci_remove_bus_device(struct pci_dev *dev)
9697
dev->subordinate = NULL;
9798
}
9899

99-
pci_bridge_d3_device_removed(dev);
100-
101100
pci_destroy_dev(dev);
102101
}
103102

0 commit comments

Comments
 (0)