Skip to content

Commit 44492e7

Browse files
khfengKalle Valo
authored andcommitted
rtw88: pci: Power cycle device during shutdown
There are reports that 8822CE fails to work rtw88 with "failed to read DBI register" error. Also I have a system with 8723DE which freezes the whole system when the rtw88 is probing the device. According to [1], platform firmware may not properly power manage the device during shutdown. I did some expirements and putting the device to D3 can workaround the issue. So let's power cycle the device by putting the device to D3 at shutdown to prevent the issue from happening. [1] https://bugzilla.kernel.org/show_bug.cgi?id=206411#c9 BugLink: https://bugs.launchpad.net/bugs/1872984 Signed-off-by: Kai-Heng Feng <[email protected]> Signed-off-by: Kalle Valo <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 6aa5a83 commit 44492e7

File tree

1 file changed

+2
-0
lines changed
  • drivers/net/wireless/realtek/rtw88

1 file changed

+2
-0
lines changed

drivers/net/wireless/realtek/rtw88/pci.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1601,6 +1601,8 @@ void rtw_pci_shutdown(struct pci_dev *pdev)
16011601

16021602
if (chip->ops->shutdown)
16031603
chip->ops->shutdown(rtwdev);
1604+
1605+
pci_set_power_state(pdev, PCI_D3hot);
16041606
}
16051607
EXPORT_SYMBOL(rtw_pci_shutdown);
16061608

0 commit comments

Comments
 (0)