Skip to content

Commit 42e6cae

Browse files
sf-hgkdavem330
authored andcommitted
sfc: revert changes to NIC revision numbers
The revision enum values (eg EFX_REV_HUNT_A0) form part of our API, and are included in ethtool. If these are inconsistent then ethtool will print garbage for a register dump (ethtool -d). Fixes: 5a6681e ("sfc: separate out SFC4000 ("Falcon") support into new sfc-falcon driver") Signed-off-by: Edward Cree <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent b12ca80 commit 42e6cae

File tree

1 file changed

+6
-2
lines changed
  • drivers/net/ethernet/sfc

1 file changed

+6
-2
lines changed

drivers/net/ethernet/sfc/nic.h

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,12 @@
1818
#include "mcdi.h"
1919

2020
enum {
21-
EFX_REV_SIENA_A0 = 0,
22-
EFX_REV_HUNT_A0 = 1,
21+
/* Revisions 0-2 were Falcon A0, A1 and B0 respectively.
22+
* They are not supported by this driver but these revision numbers
23+
* form part of the ethtool API for register dumping.
24+
*/
25+
EFX_REV_SIENA_A0 = 3,
26+
EFX_REV_HUNT_A0 = 4,
2327
};
2428

2529
static inline int efx_nic_rev(struct efx_nic *efx)

0 commit comments

Comments
 (0)