Skip to content

Commit 378ef0f

Browse files
captain5050acmel
authored andcommitted
perf build: Use libtraceevent from the system
Remove the LIBTRACEEVENT_DYNAMIC and LIBTRACEFS_DYNAMIC make command line variables. If libtraceevent isn't installed or NO_LIBTRACEEVENT=1 is passed to the build, don't compile in libtraceevent and libtracefs support. This also disables CONFIG_TRACE that controls "perf trace". CONFIG_LIBTRACEEVENT is used to control enablement in Build/Makefiles, HAVE_LIBTRACEEVENT is used in C code. Without HAVE_LIBTRACEEVENT tracepoints are disabled and as such the commands kmem, kwork, lock, sched and timechart are removed. The majority of commands continue to work including "perf test". Committer notes: Fixed up a tools/perf/util/Build reject and added: #include <traceevent/event-parse.h> to tools/perf/util/scripting-engines/trace-event-perl.c. Committer testing: $ rpm -qi libtraceevent-devel Name : libtraceevent-devel Version : 1.5.3 Release : 2.fc36 Architecture: x86_64 Install Date: Mon 25 Jul 2022 03:20:19 PM -03 Group : Unspecified Size : 27728 License : LGPLv2+ and GPLv2+ Signature : RSA/SHA256, Fri 15 Apr 2022 02:11:58 PM -03, Key ID 999f7cbf38ab71f4 Source RPM : libtraceevent-1.5.3-2.fc36.src.rpm Build Date : Fri 15 Apr 2022 10:57:01 AM -03 Build Host : buildvm-x86-05.iad2.fedoraproject.org Packager : Fedora Project Vendor : Fedora Project URL : https://git.kernel.org/pub/scm/libs/libtrace/libtraceevent.git/ Bug URL : https://bugz.fedoraproject.org/libtraceevent Summary : Development headers of libtraceevent Description : Development headers of libtraceevent-libs $ Default build: $ ldd ~/bin/perf | grep tracee libtraceevent.so.1 => /lib64/libtraceevent.so.1 (0x00007f1dcaf8f000) $ # perf trace -e sched:* --max-events 10 0.000 migration/0/17 sched:sched_migrate_task(comm: "", pid: 1603763 (perf), prio: 120, dest_cpu: 1) 0.005 migration/0/17 sched:sched_wake_idle_without_ipi(cpu: 1) 0.011 migration/0/17 sched:sched_switch(prev_comm: "", prev_pid: 17 (migration/0), prev_state: 1, next_comm: "", next_prio: 120) 1.173 :0/0 sched:sched_wakeup(comm: "", pid: 3138 (gnome-terminal-), prio: 120) 1.180 :0/0 sched:sched_switch(prev_comm: "", prev_prio: 120, next_comm: "", next_pid: 3138 (gnome-terminal-), next_prio: 120) 0.156 migration/1/21 sched:sched_migrate_task(comm: "", pid: 1603763 (perf), prio: 120, orig_cpu: 1, dest_cpu: 2) 0.160 migration/1/21 sched:sched_wake_idle_without_ipi(cpu: 2) 0.166 migration/1/21 sched:sched_switch(prev_comm: "", prev_pid: 21 (migration/1), prev_state: 1, next_comm: "", next_prio: 120) 1.183 :0/0 sched:sched_wakeup(comm: "", pid: 1602985 (kworker/u16:0-f), prio: 120, target_cpu: 1) 1.186 :0/0 sched:sched_switch(prev_comm: "", prev_prio: 120, next_comm: "", next_pid: 1602985 (kworker/u16:0-f), next_prio: 120) # Had to tweak tools/perf/util/setup.py to make sure the python binding shared object links with libtraceevent if -DHAVE_LIBTRACEEVENT is present in CFLAGS. Building with NO_LIBTRACEEVENT=1 uncovered some more build failures: - Make building of data-convert-bt.c to CONFIG_LIBTRACEEVENT=y - perf-$(CONFIG_LIBTRACEEVENT) += scripts/ - bpf_kwork.o needs also to be dependent on CONFIG_LIBTRACEEVENT=y - The python binding needed some fixups and util/trace-event.c can't be built and linked with the python binding shared object, so remove it in tools/perf/util/setup.py and exclude it from the list of dependencies in the python/perf.so Makefile.perf target. Building without libtraceevent-devel installed uncovered more build failures: - The python binding tools/perf/util/python.c was assuming that traceevent/parse-events.h was always available, which was the case when we defaulted to using the in-kernel tools/lib/traceevent/ files, now we need to enclose it under ifdef HAVE_LIBTRACEEVENT, just like the other parts of it that deal with tracepoints. - We have to ifdef the rules in the Build files with CONFIG_LIBTRACEEVENT=y to build builtin-trace.c and tools/perf/trace/beauty/ as we only ifdef setting CONFIG_TRACE=y when setting NO_LIBTRACEEVENT=1 in the make command line, not when we don't detect libtraceevent-devel installed in the system. Simplification here to avoid these two ways of disabling builtin-trace.c and not having CONFIG_TRACE=y when libtraceevent-devel isn't installed is the clean way. From Athira: <quote> tools/perf/arch/powerpc/util/Build -perf-y += kvm-stat.o +perf-$(CONFIG_LIBTRACEEVENT) += kvm-stat.o </quote> Then, ditto for arm64 and s390, detected by container cross build tests. - s/390 uses test__checkevent_tracepoint() that is now only available if HAVE_LIBTRACEEVENT is defined, enclose the callsite with ifder HAVE_LIBTRACEEVENT. Also from Athira: <quote> With this change, I could successfully compile in these environment: - Without libtraceevent-devel installed - With libtraceevent-devel installed - With “make NO_LIBTRACEEVENT=1” </quote> Then, finally rename CONFIG_TRACEEVENT to CONFIG_LIBTRACEEVENT for consistency with other libraries detected in tools/perf/. Signed-off-by: Ian Rogers <[email protected]> Tested-by: Arnaldo Carvalho de Melo <[email protected]> Tested-by: Athira Rajeev <[email protected]> Cc: Alexander Shishkin <[email protected]> Cc: Jiri Olsa <[email protected]> Cc: Mark Rutland <[email protected]> Cc: Namhyung Kim <[email protected]> Cc: Nick Desaulniers <[email protected]> Cc: Peter Zijlstra <[email protected]> Cc: Stephane Eranian <[email protected]> Cc: [email protected] Link: http://lore.kernel.org/lkml/[email protected] Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
1 parent 4076966 commit 378ef0f

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

52 files changed

+355
-184
lines changed

tools/perf/Build

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,29 +5,34 @@ perf-y += builtin-diff.o
55
perf-y += builtin-evlist.o
66
perf-y += builtin-ftrace.o
77
perf-y += builtin-help.o
8-
perf-y += builtin-sched.o
98
perf-y += builtin-buildid-list.o
109
perf-y += builtin-buildid-cache.o
1110
perf-y += builtin-kallsyms.o
1211
perf-y += builtin-list.o
1312
perf-y += builtin-record.o
1413
perf-y += builtin-report.o
1514
perf-y += builtin-stat.o
16-
perf-y += builtin-timechart.o
1715
perf-y += builtin-top.o
1816
perf-y += builtin-script.o
19-
perf-y += builtin-kmem.o
20-
perf-y += builtin-lock.o
2117
perf-y += builtin-kvm.o
2218
perf-y += builtin-inject.o
2319
perf-y += builtin-mem.o
2420
perf-y += builtin-data.o
2521
perf-y += builtin-version.o
2622
perf-y += builtin-c2c.o
2723
perf-y += builtin-daemon.o
28-
perf-y += builtin-kwork.o
2924

30-
perf-$(CONFIG_TRACE) += builtin-trace.o
25+
perf-$(CONFIG_LIBTRACEEVENT) += builtin-kmem.o
26+
perf-$(CONFIG_LIBTRACEEVENT) += builtin-kwork.o
27+
perf-$(CONFIG_LIBTRACEEVENT) += builtin-lock.o
28+
perf-$(CONFIG_LIBTRACEEVENT) += builtin-sched.o
29+
perf-$(CONFIG_LIBTRACEEVENT) += builtin-timechart.o
30+
31+
ifeq ($(CONFIG_LIBTRACEEVENT),y)
32+
perf-$(CONFIG_TRACE) += builtin-trace.o
33+
perf-$(CONFIG_TRACE) += trace/beauty/
34+
endif
35+
3136
perf-$(CONFIG_LIBELF) += builtin-probe.o
3237

3338
perf-y += bench/
@@ -51,7 +56,6 @@ CFLAGS_builtin-report.o += -DDOCDIR="BUILD_STR($(srcdir_SQ)/Documentation)"
5156
perf-y += util/
5257
perf-y += arch/
5358
perf-y += ui/
54-
perf-y += scripts/
55-
perf-$(CONFIG_TRACE) += trace/beauty/
59+
perf-$(CONFIG_LIBTRACEEVENT) += scripts/
5660

5761
gtk-y += ui/gtk/

tools/perf/Makefile.config

Lines changed: 19 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -763,18 +763,20 @@ ifndef NO_LIBUNWIND
763763
EXTLIBS += $(EXTLIBS_LIBUNWIND)
764764
endif
765765

766-
ifeq ($(NO_SYSCALL_TABLE),0)
767-
$(call detected,CONFIG_TRACE)
768-
else
769-
ifndef NO_LIBAUDIT
770-
$(call feature_check,libaudit)
771-
ifneq ($(feature-libaudit), 1)
772-
msg := $(warning No libaudit.h found, disables 'trace' tool, please install audit-libs-devel or libaudit-dev);
773-
NO_LIBAUDIT := 1
774-
else
775-
CFLAGS += -DHAVE_LIBAUDIT_SUPPORT
776-
EXTLIBS += -laudit
777-
$(call detected,CONFIG_TRACE)
766+
ifneq ($(NO_LIBTRACEEVENT),1)
767+
ifeq ($(NO_SYSCALL_TABLE),0)
768+
$(call detected,CONFIG_TRACE)
769+
else
770+
ifndef NO_LIBAUDIT
771+
$(call feature_check,libaudit)
772+
ifneq ($(feature-libaudit), 1)
773+
msg := $(warning No libaudit.h found, disables 'trace' tool, please install audit-libs-devel or libaudit-dev);
774+
NO_LIBAUDIT := 1
775+
else
776+
CFLAGS += -DHAVE_LIBAUDIT_SUPPORT
777+
EXTLIBS += -laudit
778+
$(call detected,CONFIG_TRACE)
779+
endif
778780
endif
779781
endif
780782
endif
@@ -1182,22 +1184,23 @@ ifdef LIBPFM4
11821184
endif
11831185
endif
11841186

1185-
ifdef LIBTRACEEVENT_DYNAMIC
1187+
# libtraceevent is a recommended dependency picked up from the system.
1188+
ifneq ($(NO_LIBTRACEEVENT),1)
11861189
$(call feature_check,libtraceevent)
11871190
ifeq ($(feature-libtraceevent), 1)
1191+
CFLAGS += -DHAVE_LIBTRACEEVENT
11881192
EXTLIBS += -ltraceevent
11891193
LIBTRACEEVENT_VERSION := $(shell $(PKG_CONFIG) --modversion libtraceevent)
11901194
LIBTRACEEVENT_VERSION_1 := $(word 1, $(subst ., ,$(LIBTRACEEVENT_VERSION)))
11911195
LIBTRACEEVENT_VERSION_2 := $(word 2, $(subst ., ,$(LIBTRACEEVENT_VERSION)))
11921196
LIBTRACEEVENT_VERSION_3 := $(word 3, $(subst ., ,$(LIBTRACEEVENT_VERSION)))
11931197
LIBTRACEEVENT_VERSION_CPP := $(shell expr $(LIBTRACEEVENT_VERSION_1) \* 255 \* 255 + $(LIBTRACEEVENT_VERSION_2) \* 255 + $(LIBTRACEEVENT_VERSION_3))
11941198
CFLAGS += -DLIBTRACEEVENT_VERSION=$(LIBTRACEEVENT_VERSION_CPP)
1199+
$(call detected,CONFIG_LIBTRACEEVENT)
11951200
else
1196-
dummy := $(error Error: No libtraceevent devel library found, please install libtraceevent-devel);
1201+
dummy := $(warning Warning: libtraceevent is missing limiting functionality, please install libtraceevent-dev/libtraceevent-devel)
11971202
endif
1198-
endif
11991203

1200-
ifdef LIBTRACEFS_DYNAMIC
12011204
$(call feature_check,libtracefs)
12021205
ifeq ($(feature-libtracefs), 1)
12031206
EXTLIBS += -ltracefs
@@ -1207,8 +1210,6 @@ ifdef LIBTRACEFS_DYNAMIC
12071210
LIBTRACEFS_VERSION_3 := $(word 3, $(subst ., ,$(LIBTRACEFS_VERSION)))
12081211
LIBTRACEFS_VERSION_CPP := $(shell expr $(LIBTRACEFS_VERSION_1) \* 255 \* 255 + $(LIBTRACEFS_VERSION_2) \* 255 + $(LIBTRACEFS_VERSION_3))
12091212
CFLAGS += -DLIBTRACEFS_VERSION=$(LIBTRACEFS_VERSION_CPP)
1210-
else
1211-
dummy := $(error Error: No libtracefs devel library found, please install libtracefs-dev);
12121213
endif
12131214
endif
12141215

tools/perf/Makefile.perf

Lines changed: 10 additions & 94 deletions
Original file line numberDiff line numberDiff line change
@@ -128,10 +128,6 @@ include ../scripts/utilities.mak
128128
#
129129
# Define BUILD_BPF_SKEL to enable BPF skeletons
130130
#
131-
# Define LIBTRACEEVENT_DYNAMIC to enable libtraceevent dynamic linking
132-
#
133-
# Define LIBTRACEFS_DYNAMIC to enable libtracefs dynamic linking
134-
#
135131

136132
# As per kernel Makefile, avoid funny character set dependencies
137133
unexport LC_ALL
@@ -242,10 +238,6 @@ sub-make: fixdep
242238
else # force_fixdep
243239

244240
LIBAPI_DIR = $(srctree)/tools/lib/api/
245-
ifndef LIBTRACEEVENT_DYNAMIC
246-
LIBTRACEEVENT_DIR = $(srctree)/tools/lib/traceevent/
247-
LIBTRACEEVENT_PLUGINS_DIR = $(LIBTRACEEVENT_DIR)/plugins
248-
endif
249241
LIBBPF_DIR = $(srctree)/tools/lib/bpf/
250242
LIBSUBCMD_DIR = $(srctree)/tools/lib/subcmd/
251243
LIBSYMBOL_DIR = $(srctree)/tools/lib/symbol/
@@ -295,31 +287,6 @@ SCRIPT_SH += perf-iostat.sh
295287
grep-libs = $(filter -l%,$(1))
296288
strip-libs = $(filter-out -l%,$(1))
297289

298-
ifndef LIBTRACEEVENT_DYNAMIC
299-
ifneq ($(OUTPUT),)
300-
LIBTRACEEVENT_OUTPUT = $(abspath $(OUTPUT))/libtraceevent
301-
else
302-
LIBTRACEEVENT_OUTPUT = $(CURDIR)/libtraceevent
303-
endif
304-
LIBTRACEEVENT_PLUGINS_OUTPUT = $(LIBTRACEEVENT_OUTPUT)_plugins
305-
LIBTRACEEVENT_DESTDIR = $(LIBTRACEEVENT_OUTPUT)
306-
LIBTRACEEVENT_PLUGINS_DESTDIR = $(LIBTRACEEVENT_PLUGINS_OUTPUT)
307-
LIBTRACEEVENT_INCLUDE = $(LIBTRACEEVENT_DESTDIR)/include
308-
LIBTRACEEVENT = $(LIBTRACEEVENT_OUTPUT)/libtraceevent.a
309-
export LIBTRACEEVENT
310-
LIBTRACEEVENT_DYNAMIC_LIST = $(LIBTRACEEVENT_PLUGINS_OUTPUT)/libtraceevent-dynamic-list
311-
CFLAGS += -I$(LIBTRACEEVENT_OUTPUT)/include
312-
#
313-
# The static build has no dynsym table, so this does not work for
314-
# static build. Looks like linker starts to scream about that now
315-
# (in Fedora 26) so we need to switch it off for static build.
316-
DYNAMIC_LIST_LDFLAGS = -Xlinker --dynamic-list=$(LIBTRACEEVENT_DYNAMIC_LIST)
317-
LIBTRACEEVENT_DYNAMIC_LIST_LDFLAGS = $(if $(findstring -static,$(LDFLAGS)),,$(DYNAMIC_LIST_LDFLAGS))
318-
else
319-
LIBTRACEEVENT_DYNAMIC_LIST =
320-
LIBTRACEEVENT_DYNAMIC_LIST_LDFLAGS =
321-
endif
322-
323290
ifneq ($(OUTPUT),)
324291
LIBAPI_OUTPUT = $(abspath $(OUTPUT))/libapi
325292
else
@@ -380,13 +347,14 @@ export PYTHON_EXTBUILD_LIB PYTHON_EXTBUILD_TMP
380347

381348
python-clean := $(call QUIET_CLEAN, python) $(RM) -r $(PYTHON_EXTBUILD) $(OUTPUT)python/perf*.so
382349

383-
PYTHON_EXT_SRCS := $(shell grep -v ^\# util/python-ext-sources)
384-
ifndef LIBTRACEEVENT_DYNAMIC
385-
PYTHON_EXT_DEPS := util/python-ext-sources util/setup.py $(LIBTRACEEVENT) $(LIBAPI)
350+
ifeq ($(CONFIG_LIBTRACEEVENT),y)
351+
PYTHON_EXT_SRCS := $(shell grep -v ^\# util/python-ext-sources)
386352
else
387-
PYTHON_EXT_DEPS := util/python-ext-sources util/setup.py $(LIBAPI)
353+
PYTHON_EXT_SRCS := $(shell grep -v '^\#\|util/trace-event.c' util/python-ext-sources)
388354
endif
389355

356+
PYTHON_EXT_DEPS := util/python-ext-sources util/setup.py $(LIBAPI)
357+
390358
SCRIPTS = $(patsubst %.sh,%,$(SCRIPT_SH))
391359

392360
PROGRAMS += $(OUTPUT)perf
@@ -430,9 +398,6 @@ ifndef NO_LIBBPF
430398
PERFLIBS += $(LIBBPF)
431399
endif
432400
endif
433-
ifndef LIBTRACEEVENT_DYNAMIC
434-
PERFLIBS += $(LIBTRACEEVENT)
435-
endif
436401

437402
# We choose to avoid "if .. else if .. else .. endif endif"
438403
# because maintaining the nesting to match is a pain. If
@@ -682,9 +647,9 @@ all: shell_compatibility_test $(ALL_PROGRAMS) $(LANG_BINDINGS) $(OTHER_PROGRAMS)
682647
# Create python binding output directory if not already present
683648
_dummy := $(shell [ -d '$(OUTPUT)python' ] || mkdir -p '$(OUTPUT)python')
684649

685-
$(OUTPUT)python/perf.so: $(PYTHON_EXT_SRCS) $(PYTHON_EXT_DEPS) $(LIBTRACEEVENT_DYNAMIC_LIST) $(LIBPERF)
650+
$(OUTPUT)python/perf.so: $(PYTHON_EXT_SRCS) $(PYTHON_EXT_DEPS) $(LIBPERF)
686651
$(QUIET_GEN)LDSHARED="$(CC) -pthread -shared" \
687-
CFLAGS='$(CFLAGS)' LDFLAGS='$(LDFLAGS) $(LIBTRACEEVENT_DYNAMIC_LIST_LDFLAGS)' \
652+
CFLAGS='$(CFLAGS)' LDFLAGS='$(LDFLAGS)' \
688653
$(PYTHON_WORD) util/setup.py \
689654
--quiet build_ext; \
690655
cp $(PYTHON_EXTBUILD_LIB)perf*.so $(OUTPUT)python/
@@ -710,8 +675,8 @@ $(PERF_IN): prepare FORCE
710675
$(PMU_EVENTS_IN): FORCE prepare
711676
$(Q)$(MAKE) -f $(srctree)/tools/build/Makefile.build dir=pmu-events obj=pmu-events
712677

713-
$(OUTPUT)perf: $(PERFLIBS) $(PERF_IN) $(PMU_EVENTS_IN) $(LIBTRACEEVENT_DYNAMIC_LIST)
714-
$(QUIET_LINK)$(CC) $(CFLAGS) $(LDFLAGS) $(LIBTRACEEVENT_DYNAMIC_LIST_LDFLAGS) \
678+
$(OUTPUT)perf: $(PERFLIBS) $(PERF_IN) $(PMU_EVENTS_IN)
679+
$(QUIET_LINK)$(CC) $(CFLAGS) $(LDFLAGS) \
715680
$(PERF_IN) $(PMU_EVENTS_IN) $(LIBS) -o $@
716681

717682
$(GTK_IN): FORCE prepare
@@ -797,10 +762,6 @@ prepare: $(OUTPUT)PERF-VERSION-FILE $(OUTPUT)common-cmds.h archheaders $(drm_ioc
797762
$(LIBSYMBOL) \
798763
bpf-skel
799764

800-
ifndef LIBTRACEEVENT_DYNAMIC
801-
prepare: $(LIBTRACEEVENT)
802-
endif
803-
804765
$(OUTPUT)%.o: %.c prepare FORCE
805766
$(Q)$(MAKE) -f $(srctree)/tools/build/Makefile.build dir=$(build-dir) $@
806767

@@ -856,38 +817,6 @@ endif
856817

857818
$(patsubst perf-%,%.o,$(PROGRAMS)): $(wildcard */*.h)
858819

859-
ifndef LIBTRACEEVENT_DYNAMIC
860-
LIBTRACEEVENT_FLAGS += plugin_dir=$(plugindir_SQ) 'EXTRA_CFLAGS=$(EXTRA_CFLAGS)' 'LDFLAGS=$(filter-out -static,$(LDFLAGS))'
861-
862-
$(LIBTRACEEVENT): FORCE | $(LIBTRACEEVENT_OUTPUT)
863-
$(Q)$(MAKE) -C $(LIBTRACEEVENT_DIR) O=$(LIBTRACEEVENT_OUTPUT) \
864-
DESTDIR=$(LIBTRACEEVENT_DESTDIR) prefix= \
865-
$@ install_headers
866-
867-
$(LIBTRACEEVENT)-clean:
868-
$(call QUIET_CLEAN, libtraceevent)
869-
$(Q)$(RM) -r -- $(LIBTRACEEVENT_OUTPUT)
870-
871-
libtraceevent_plugins: FORCE | $(LIBTRACEEVENT_PLUGINS_OUTPUT)
872-
$(Q)$(MAKE) -C $(LIBTRACEEVENT_PLUGINS_DIR) O=$(LIBTRACEEVENT_PLUGINS_OUTPUT) \
873-
DESTDIR=$(LIBTRACEEVENT_PLUGINS_DESTDIR) prefix= \
874-
plugins
875-
876-
libtraceevent_plugins-clean:
877-
$(call QUIET_CLEAN, libtraceevent_plugins)
878-
$(Q)$(RM) -r -- $(LIBTRACEEVENT_PLUGINS_OUTPUT)
879-
880-
$(LIBTRACEEVENT_DYNAMIC_LIST): libtraceevent_plugins
881-
$(Q)$(MAKE) -C $(LIBTRACEEVENT_PLUGINS_DIR) O=$(LIBTRACEEVENT_PLUGINS_OUTPUT) \
882-
DESTDIR=$(LIBTRACEEVENT_PLUGINS_DESTDIR) prefix= \
883-
$(LIBTRACEEVENT_FLAGS) $@
884-
885-
install-traceevent-plugins: libtraceevent_plugins
886-
$(Q)$(MAKE) -C $(LIBTRACEEVENT_PLUGINS_DIR) O=$(LIBTRACEEVENT_PLUGINS_OUTPUT) \
887-
DESTDIR=$(DESTDIR_SQ)$(prefix) prefix= \
888-
$(LIBTRACEEVENT_FLAGS) install
889-
endif
890-
891820
$(LIBAPI): FORCE | $(LIBAPI_OUTPUT)
892821
$(Q)$(MAKE) -C $(LIBAPI_DIR) O=$(LIBAPI_OUTPUT) \
893822
DESTDIR=$(LIBAPI_DESTDIR) prefix= \
@@ -1095,10 +1024,6 @@ install-tests: all install-gtk
10951024

10961025
install-bin: install-tools install-tests
10971026

1098-
ifndef LIBTRACEEVENT_DYNAMIC
1099-
install-bin: install-traceevent-plugins
1100-
endif
1101-
11021027
install: install-bin try-install-man
11031028

11041029
install-python_ext:
@@ -1124,11 +1049,6 @@ SKELETONS += $(SKEL_OUT)/kwork_trace.skel.h
11241049
$(SKEL_TMP_OUT) $(LIBAPI_OUTPUT) $(LIBBPF_OUTPUT) $(LIBPERF_OUTPUT) $(LIBSUBCMD_OUTPUT) $(LIBSYMBOL_OUTPUT):
11251050
$(Q)$(MKDIR) -p $@
11261051

1127-
ifndef LIBTRACEEVENT_DYNAMIC
1128-
$(LIBTRACEEVENT_OUTPUT) $(LIBTRACEEVENT_PLUGINS_OUTPUT):
1129-
$(Q)$(MKDIR) -p $@
1130-
endif
1131-
11321052
ifdef BUILD_BPF_SKEL
11331053
BPFTOOL := $(SKEL_TMP_OUT)/bootstrap/bpftool
11341054
BPF_INCLUDE := -I$(SKEL_TMP_OUT)/.. -I$(LIBBPF_INCLUDE)
@@ -1211,10 +1131,6 @@ clean:: $(LIBAPI)-clean $(LIBBPF)-clean $(LIBSUBCMD)-clean $(LIBSYMBOL)-clean $(
12111131
$(call QUIET_CLEAN, Documentation) \
12121132
$(MAKE) -C $(DOC_DIR) O=$(OUTPUT) clean >/dev/null
12131133

1214-
ifndef LIBTRACEEVENT_DYNAMIC
1215-
clean:: $(LIBTRACEEVENT)-clean libtraceevent_plugins-clean
1216-
endif
1217-
12181134
#
12191135
# To provide FEATURE-DUMP into $(FEATURE_DUMP_COPY)
12201136
# file if defined, with no further action.
@@ -1232,6 +1148,6 @@ FORCE:
12321148
.PHONY: all install clean config-clean strip install-gtk
12331149
.PHONY: shell_compatibility_test please_set_SHELL_PATH_to_a_more_modern_shell
12341150
.PHONY: .FORCE-PERF-VERSION-FILE TAGS tags cscope FORCE prepare
1235-
.PHONY: libtraceevent_plugins archheaders
1151+
.PHONY: archheaders
12361152

12371153
endif # force_fixdep

tools/perf/arch/arm64/util/Build

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ perf-y += machine.o
33
perf-y += perf_regs.o
44
perf-y += tsc.o
55
perf-y += pmu.o
6-
perf-y += kvm-stat.o
6+
perf-$(CONFIG_LIBTRACEEVENT) += kvm-stat.o
77
perf-$(CONFIG_DWARF) += dwarf-regs.o
88
perf-$(CONFIG_LOCAL_LIBUNWIND) += unwind-libunwind.o
99
perf-$(CONFIG_LIBDW_DWARF_UNWIND) += unwind-libdw.o

tools/perf/arch/powerpc/util/Build

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
perf-y += header.o
2-
perf-y += kvm-stat.o
2+
perf-$(CONFIG_LIBTRACEEVENT) += kvm-stat.o
33
perf-y += perf_regs.o
44
perf-y += mem-events.o
55
perf-y += sym-handling.o

tools/perf/arch/s390/util/Build

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
perf-y += header.o
2-
perf-y += kvm-stat.o
2+
perf-$(CONFIG_LIBTRACEEVENT) += kvm-stat.o
33
perf-y += perf_regs.o
44

55
perf-$(CONFIG_DWARF) += dwarf-regs.o

tools/perf/arch/x86/util/Build

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
perf-y += header.o
22
perf-y += tsc.o
33
perf-y += pmu.o
4-
perf-y += kvm-stat.o
4+
perf-$(CONFIG_LIBTRACEEVENT) += kvm-stat.o
55
perf-y += perf_regs.o
66
perf-y += topdown.o
77
perf-y += machine.o

tools/perf/arch/x86/util/intel-pt.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -418,6 +418,7 @@ static int intel_pt_info_fill(struct auxtrace_record *itr,
418418
return 0;
419419
}
420420

421+
#ifdef HAVE_LIBTRACEEVENT
421422
static int intel_pt_track_switches(struct evlist *evlist)
422423
{
423424
const char *sched_switch = "sched:sched_switch";
@@ -439,6 +440,7 @@ static int intel_pt_track_switches(struct evlist *evlist)
439440

440441
return 0;
441442
}
443+
#endif
442444

443445
static void intel_pt_valid_str(char *str, size_t len, u64 valid)
444446
{
@@ -829,13 +831,15 @@ static int intel_pt_recording_options(struct auxtrace_record *itr,
829831
ptr->have_sched_switch = 2;
830832
}
831833
} else {
834+
#ifdef HAVE_LIBTRACEEVENT
832835
err = intel_pt_track_switches(evlist);
833836
if (err == -EPERM)
834837
pr_debug2("Unable to select sched:sched_switch\n");
835838
else if (err)
836839
return err;
837840
else
838841
ptr->have_sched_switch = 1;
842+
#endif
839843
}
840844
}
841845

tools/perf/builtin-annotate.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -499,7 +499,9 @@ int cmd_annotate(int argc, const char **argv)
499499
.namespaces = perf_event__process_namespaces,
500500
.attr = perf_event__process_attr,
501501
.build_id = perf_event__process_build_id,
502+
#ifdef HAVE_LIBTRACEEVENT
502503
.tracing_data = perf_event__process_tracing_data,
504+
#endif
503505
.id_index = perf_event__process_id_index,
504506
.auxtrace_info = perf_event__process_auxtrace_info,
505507
.auxtrace = perf_event__process_auxtrace,

0 commit comments

Comments
 (0)