Skip to content

Commit 3574cfd

Browse files
committed
RDMA/mana: Remove redefinition of basic u64 type
gdma_obj_handle_t is no more than redefinition of basic u64 type. Remove such obfuscation. Link: https://lore.kernel.org/r/3c1e821279e6a165d058655d2343722d6650e776.1668160486.git.leonro@nvidia.com Acked-by: Long Li <[email protected]> Signed-off-by: Leon Romanovsky <[email protected]>
1 parent 0266a17 commit 3574cfd

File tree

3 files changed

+17
-22
lines changed

3 files changed

+17
-22
lines changed

drivers/infiniband/hw/mana/mr.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,7 @@ static int mana_ib_gd_create_mr(struct mana_ib_dev *dev, struct mana_ib_mr *mr,
7373
return 0;
7474
}
7575

76-
static int mana_ib_gd_destroy_mr(struct mana_ib_dev *dev,
77-
gdma_obj_handle_t mr_handle)
76+
static int mana_ib_gd_destroy_mr(struct mana_ib_dev *dev, u64 mr_handle)
7877
{
7978
struct gdma_destroy_mr_response resp = {};
8079
struct gdma_destroy_mr_request req = {};
@@ -108,9 +107,9 @@ struct ib_mr *mana_ib_reg_user_mr(struct ib_pd *ibpd, u64 start, u64 length,
108107
struct mana_ib_pd *pd = container_of(ibpd, struct mana_ib_pd, ibpd);
109108
struct gdma_create_mr_params mr_params = {};
110109
struct ib_device *ibdev = ibpd->device;
111-
gdma_obj_handle_t dma_region_handle;
112110
struct mana_ib_dev *dev;
113111
struct mana_ib_mr *mr;
112+
u64 dma_region_handle;
114113
int err;
115114

116115
dev = container_of(ibdev, struct mana_ib_dev, ib_dev);

drivers/net/ethernet/microsoft/mana/gdma_main.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -671,8 +671,7 @@ int mana_gd_create_hwc_queue(struct gdma_dev *gd,
671671
return err;
672672
}
673673

674-
int mana_gd_destroy_dma_region(struct gdma_context *gc,
675-
gdma_obj_handle_t dma_region_handle)
674+
int mana_gd_destroy_dma_region(struct gdma_context *gc, u64 dma_region_handle)
676675
{
677676
struct gdma_destroy_dma_region_req req = {};
678677
struct gdma_general_resp resp = {};

include/net/mana/gdma.h

Lines changed: 14 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,6 @@ enum {
6565
GDMA_DEVICE_MANA = 2,
6666
};
6767

68-
typedef u64 gdma_obj_handle_t;
69-
7068
struct gdma_resource {
7169
/* Protect the bitmap */
7270
spinlock_t lock;
@@ -200,7 +198,7 @@ struct gdma_mem_info {
200198
u64 length;
201199

202200
/* Allocated by the PF driver */
203-
gdma_obj_handle_t dma_region_handle;
201+
u64 dma_region_handle;
204202
};
205203

206204
#define REGISTER_ATB_MST_MKEY_LOWER_SIZE 8
@@ -624,7 +622,7 @@ struct gdma_create_queue_req {
624622
u32 reserved1;
625623
u32 pdid;
626624
u32 doolbell_id;
627-
gdma_obj_handle_t gdma_region;
625+
u64 gdma_region;
628626
u32 reserved2;
629627
u32 queue_size;
630628
u32 log2_throttle_limit;
@@ -699,14 +697,14 @@ struct gdma_create_dma_region_req {
699697

700698
struct gdma_create_dma_region_resp {
701699
struct gdma_resp_hdr hdr;
702-
gdma_obj_handle_t dma_region_handle;
700+
u64 dma_region_handle;
703701
}; /* HW DATA */
704702

705703
/* GDMA_DMA_REGION_ADD_PAGES */
706704
struct gdma_dma_region_add_pages_req {
707705
struct gdma_req_hdr hdr;
708706

709-
gdma_obj_handle_t dma_region_handle;
707+
u64 dma_region_handle;
710708

711709
u32 page_addr_list_len;
712710
u32 reserved3;
@@ -718,7 +716,7 @@ struct gdma_dma_region_add_pages_req {
718716
struct gdma_destroy_dma_region_req {
719717
struct gdma_req_hdr hdr;
720718

721-
gdma_obj_handle_t dma_region_handle;
719+
u64 dma_region_handle;
722720
}; /* HW DATA */
723721

724722
enum gdma_pd_flags {
@@ -733,14 +731,14 @@ struct gdma_create_pd_req {
733731

734732
struct gdma_create_pd_resp {
735733
struct gdma_resp_hdr hdr;
736-
gdma_obj_handle_t pd_handle;
734+
u64 pd_handle;
737735
u32 pd_id;
738736
u32 reserved;
739737
};/* HW DATA */
740738

741739
struct gdma_destroy_pd_req {
742740
struct gdma_req_hdr hdr;
743-
gdma_obj_handle_t pd_handle;
741+
u64 pd_handle;
744742
};/* HW DATA */
745743

746744
struct gdma_destory_pd_resp {
@@ -756,11 +754,11 @@ enum gdma_mr_type {
756754
};
757755

758756
struct gdma_create_mr_params {
759-
gdma_obj_handle_t pd_handle;
757+
u64 pd_handle;
760758
enum gdma_mr_type mr_type;
761759
union {
762760
struct {
763-
gdma_obj_handle_t dma_region_handle;
761+
u64 dma_region_handle;
764762
u64 virtual_address;
765763
enum gdma_mr_access_flags access_flags;
766764
} gva;
@@ -769,13 +767,13 @@ struct gdma_create_mr_params {
769767

770768
struct gdma_create_mr_request {
771769
struct gdma_req_hdr hdr;
772-
gdma_obj_handle_t pd_handle;
770+
u64 pd_handle;
773771
enum gdma_mr_type mr_type;
774772
u32 reserved_1;
775773

776774
union {
777775
struct {
778-
gdma_obj_handle_t dma_region_handle;
776+
u64 dma_region_handle;
779777
u64 virtual_address;
780778
enum gdma_mr_access_flags access_flags;
781779
} gva;
@@ -786,14 +784,14 @@ struct gdma_create_mr_request {
786784

787785
struct gdma_create_mr_response {
788786
struct gdma_resp_hdr hdr;
789-
gdma_obj_handle_t mr_handle;
787+
u64 mr_handle;
790788
u32 lkey;
791789
u32 rkey;
792790
};/* HW DATA */
793791

794792
struct gdma_destroy_mr_request {
795793
struct gdma_req_hdr hdr;
796-
gdma_obj_handle_t mr_handle;
794+
u64 mr_handle;
797795
};/* HW DATA */
798796

799797
struct gdma_destroy_mr_response {
@@ -827,7 +825,6 @@ void mana_gd_free_memory(struct gdma_mem_info *gmi);
827825
int mana_gd_send_request(struct gdma_context *gc, u32 req_len, const void *req,
828826
u32 resp_len, void *resp);
829827

830-
int mana_gd_destroy_dma_region(struct gdma_context *gc,
831-
gdma_obj_handle_t dma_region_handle);
828+
int mana_gd_destroy_dma_region(struct gdma_context *gc, u64 dma_region_handle);
832829

833830
#endif /* _GDMA_H */

0 commit comments

Comments
 (0)