Skip to content

Commit 3079c22

Browse files
jankaraaxboe
authored andcommitted
genhd: Rename get_disk() to get_disk_and_module()
Rename get_disk() to get_disk_and_module() to make sure what the function does. It's not a great name but at least it is now clear that put_disk() is not it's counterpart. Signed-off-by: Jan Kara <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
1 parent d52987b commit 3079c22

File tree

10 files changed

+13
-15
lines changed

10 files changed

+13
-15
lines changed

block/genhd.c

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -547,7 +547,7 @@ static int exact_lock(dev_t devt, void *data)
547547
{
548548
struct gendisk *p = data;
549549

550-
if (!get_disk(p))
550+
if (!get_disk_and_module(p))
551551
return -1;
552552
return 0;
553553
}
@@ -809,7 +809,7 @@ struct gendisk *get_gendisk(dev_t devt, int *partno)
809809

810810
spin_lock_bh(&ext_devt_lock);
811811
part = idr_find(&ext_devt_idr, blk_mangle_minor(MINOR(devt)));
812-
if (part && get_disk(part_to_disk(part))) {
812+
if (part && get_disk_and_module(part_to_disk(part))) {
813813
*partno = part->partno;
814814
disk = part_to_disk(part);
815815
}
@@ -1456,7 +1456,7 @@ struct gendisk *__alloc_disk_node(int minors, int node_id)
14561456
}
14571457
EXPORT_SYMBOL(__alloc_disk_node);
14581458

1459-
struct kobject *get_disk(struct gendisk *disk)
1459+
struct kobject *get_disk_and_module(struct gendisk *disk)
14601460
{
14611461
struct module *owner;
14621462
struct kobject *kobj;
@@ -1474,15 +1474,13 @@ struct kobject *get_disk(struct gendisk *disk)
14741474
return kobj;
14751475

14761476
}
1477-
1478-
EXPORT_SYMBOL(get_disk);
1477+
EXPORT_SYMBOL(get_disk_and_module);
14791478

14801479
void put_disk(struct gendisk *disk)
14811480
{
14821481
if (disk)
14831482
kobject_put(&disk_to_dev(disk)->kobj);
14841483
}
1485-
14861484
EXPORT_SYMBOL(put_disk);
14871485

14881486
static void set_disk_ro_uevent(struct gendisk *gd, int ro)

drivers/block/amiflop.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1758,7 +1758,7 @@ static struct kobject *floppy_find(dev_t dev, int *part, void *data)
17581758
if (unit[drive].type->code == FD_NODRIVE)
17591759
return NULL;
17601760
*part = 0;
1761-
return get_disk(unit[drive].gendisk);
1761+
return get_disk_and_module(unit[drive].gendisk);
17621762
}
17631763

17641764
static int __init amiga_floppy_probe(struct platform_device *pdev)

drivers/block/ataflop.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1917,7 +1917,7 @@ static struct kobject *floppy_find(dev_t dev, int *part, void *data)
19171917
if (drive >= FD_MAX_UNITS || type > NUM_DISK_MINORS)
19181918
return NULL;
19191919
*part = 0;
1920-
return get_disk(unit[drive].disk);
1920+
return get_disk_and_module(unit[drive].disk);
19211921
}
19221922

19231923
static int __init atari_floppy_init (void)

drivers/block/brd.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -456,7 +456,7 @@ static struct kobject *brd_probe(dev_t dev, int *part, void *data)
456456

457457
mutex_lock(&brd_devices_mutex);
458458
brd = brd_init_one(MINOR(dev) / max_part, &new);
459-
kobj = brd ? get_disk(brd->brd_disk) : NULL;
459+
kobj = brd ? get_disk_and_module(brd->brd_disk) : NULL;
460460
mutex_unlock(&brd_devices_mutex);
461461

462462
if (new)

drivers/block/floppy.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4505,7 +4505,7 @@ static struct kobject *floppy_find(dev_t dev, int *part, void *data)
45054505
if (((*part >> 2) & 0x1f) >= ARRAY_SIZE(floppy_type))
45064506
return NULL;
45074507
*part = 0;
4508-
return get_disk(disks[drive]);
4508+
return get_disk_and_module(disks[drive]);
45094509
}
45104510

45114511
static int __init do_floppy_init(void)

drivers/block/loop.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1922,7 +1922,7 @@ static struct kobject *loop_probe(dev_t dev, int *part, void *data)
19221922
if (err < 0)
19231923
kobj = NULL;
19241924
else
1925-
kobj = get_disk(lo->lo_disk);
1925+
kobj = get_disk_and_module(lo->lo_disk);
19261926
mutex_unlock(&loop_index_mutex);
19271927

19281928
*part = 0;

drivers/block/swim.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -799,7 +799,7 @@ static struct kobject *floppy_find(dev_t dev, int *part, void *data)
799799
return NULL;
800800

801801
*part = 0;
802-
return get_disk(swd->unit[drive].disk);
802+
return get_disk_and_module(swd->unit[drive].disk);
803803
}
804804

805805
static int swim_add_floppy(struct swim_priv *swd, enum drive_location location)

drivers/block/z2ram.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -332,7 +332,7 @@ static const struct block_device_operations z2_fops =
332332
static struct kobject *z2_find(dev_t dev, int *part, void *data)
333333
{
334334
*part = 0;
335-
return get_disk(z2ram_gendisk);
335+
return get_disk_and_module(z2ram_gendisk);
336336
}
337337

338338
static struct request_queue *z2_queue;

drivers/ide/ide-probe.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -928,7 +928,7 @@ static int exact_lock(dev_t dev, void *data)
928928
{
929929
struct gendisk *p = data;
930930

931-
if (!get_disk(p))
931+
if (!get_disk_and_module(p))
932932
return -1;
933933
return 0;
934934
}

include/linux/genhd.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -600,7 +600,7 @@ extern void delete_partition(struct gendisk *, int);
600600
extern void printk_all_partitions(void);
601601

602602
extern struct gendisk *__alloc_disk_node(int minors, int node_id);
603-
extern struct kobject *get_disk(struct gendisk *disk);
603+
extern struct kobject *get_disk_and_module(struct gendisk *disk);
604604
extern void put_disk(struct gendisk *disk);
605605
extern void blk_register_region(dev_t devt, unsigned long range,
606606
struct module *module,

0 commit comments

Comments
 (0)