mlxsw: Call free_netdev when removing port

idosch · davem330 · commit 26a80f6e542e · 2015-08-09T22:54:09.000-07:00
When removing a port's netdevice we should also free the memory
allocated by alloc_etherdev(). Do this by calling free_netdev() at the
end of the teardown sequence.

Reported-by: Or Gerlitz &lt;ogerlitz@mellanox.com&gt;
Signed-off-by: Ido Schimmel &lt;idosch@mellanox.com&gt;
Signed-off-by: Jiri Pirko &lt;jiri@mellanox.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/ethernet/mellanox/mlxsw/switchx2.c b/drivers/net/ethernet/mellanox/mlxsw/switchx2.c
@@ -1079,6 +1079,7 @@ static void mlxsw_sx_port_remove(struct mlxsw_sx *mlxsw_sx, u8 local_port)
 	unregister_netdev(mlxsw_sx_port->dev); /* This calls ndo_stop */
 	mlxsw_sx_port_swid_set(mlxsw_sx_port, MLXSW_PORT_SWID_DISABLED_PORT);
 	free_percpu(mlxsw_sx_port->pcpu_stats);
+	free_netdev(mlxsw_sx_port->dev);
 }
 
 static void mlxsw_sx_ports_remove(struct mlxsw_sx *mlxsw_sx)

Original file line number	Diff line number	Diff line change
`@@ -1079,6 +1079,7 @@ static void mlxsw_sx_port_remove(struct mlxsw_sx *mlxsw_sx, u8 local_port)`
`1079`	`1079`	`unregister_netdev(mlxsw_sx_port->dev); /* This calls ndo_stop */`
`1080`	`1080`	`mlxsw_sx_port_swid_set(mlxsw_sx_port, MLXSW_PORT_SWID_DISABLED_PORT);`
`1081`	`1081`	`free_percpu(mlxsw_sx_port->pcpu_stats);`
	`1082`	`+ free_netdev(mlxsw_sx_port->dev);`
`1082`	`1083`	`}`
`1083`	`1084`
`1084`	`1085`	`static void mlxsw_sx_ports_remove(struct mlxsw_sx *mlxsw_sx)`