Skip to content

Commit 2450cf5

Browse files
committed
Revert "menu: fix embedded menu snafu"
This reverts commit 155b25b, which was totally wrong - the "embedded" options still exists (very much so) even on non-embedded platforms. It's just that we don't bother with actually asking about them when we're not embedded, we just take their default values (which is usually 'y' - the options add features that may not be worth it in a constrained environment). Noticed-by: Andrew Morton <[email protected]> Cc: Randy Dunlap <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent 43e4070 commit 2450cf5

File tree

1 file changed

+12
-16
lines changed

1 file changed

+12
-16
lines changed

init/Kconfig

Lines changed: 12 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -683,8 +683,6 @@ menuconfig EMBEDDED
683683
environments which can tolerate a "non-standard" kernel.
684684
Only use this if you really know what you are doing.
685685

686-
if EMBEDDED
687-
688686
config UID16
689687
bool "Enable 16-bit UID system calls" if EMBEDDED
690688
depends on ARM || BLACKFIN || CRIS || FRV || H8300 || X86_32 || M68K || (S390 && !64BIT) || SUPERH || SPARC32 || (SPARC64 && COMPAT) || UML || (X86_64 && IA32_EMULATION)
@@ -782,6 +780,18 @@ config PCSPKR_PLATFORM
782780
This option allows to disable the internal PC-Speaker
783781
support, saving some memory.
784782

783+
config COMPAT_BRK
784+
bool "Disable heap randomization"
785+
default y
786+
help
787+
Randomizing heap placement makes heap exploits harder, but it
788+
also breaks ancient binaries (including anything libc5 based).
789+
This option changes the bootup default to heap randomization
790+
disabled, and can be overriden runtime by setting
791+
/proc/sys/kernel/randomize_va_space to 2.
792+
793+
On non-ancient distros (post-2000 ones) N is usually a safe choice.
794+
785795
config BASE_FULL
786796
default y
787797
bool "Enable full-sized data structures for core" if EMBEDDED
@@ -887,20 +897,6 @@ config SLUB_DEBUG
887897
SLUB sysfs support. /sys/slab will not exist and there will be
888898
no support for cache validation etc.
889899

890-
endif # EMBEDDED
891-
892-
config COMPAT_BRK
893-
bool "Disable heap randomization"
894-
default y
895-
help
896-
Randomizing heap placement makes heap exploits harder, but it
897-
also breaks ancient binaries (including anything libc5 based).
898-
This option changes the bootup default to heap randomization
899-
disabled, and can be overriden runtime by setting
900-
/proc/sys/kernel/randomize_va_space to 2.
901-
902-
On non-ancient distros (post-2000 ones) N is usually a safe choice.
903-
904900
choice
905901
prompt "Choose SLAB allocator"
906902
default SLUB

0 commit comments

Comments
 (0)