Skip to content

Commit 231ee8b

Browse files
Jiapeng Zhongholtmann
Jiapeng Zhong
authored and
holtmann
committed
Bluetooth: fix coccicheck warnings debugfs
Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE for debugfs files. Reported-by: Abaci Robot<[email protected]> Signed-off-by: Jiapeng Zhong <[email protected]> Signed-off-by: Marcel Holtmann <[email protected]>
1 parent 219991e commit 231ee8b

File tree

1 file changed

+40
-40
lines changed

1 file changed

+40
-40
lines changed

‎net/bluetooth/hci_debugfs.c‎

Lines changed: 40 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -237,8 +237,8 @@ static int conn_info_min_age_get(void *data, u64 *val)
237237
return 0;
238238
}
239239

240-
DEFINE_SIMPLE_ATTRIBUTE(conn_info_min_age_fops, conn_info_min_age_get,
241-
conn_info_min_age_set, "%llu\n");
240+
DEFINE_DEBUGFS_ATTRIBUTE(conn_info_min_age_fops, conn_info_min_age_get,
241+
conn_info_min_age_set, "%llu\n");
242242

243243
static int conn_info_max_age_set(void *data, u64 val)
244244
{
@@ -265,8 +265,8 @@ static int conn_info_max_age_get(void *data, u64 *val)
265265
return 0;
266266
}
267267

268-
DEFINE_SIMPLE_ATTRIBUTE(conn_info_max_age_fops, conn_info_max_age_get,
269-
conn_info_max_age_set, "%llu\n");
268+
DEFINE_DEBUGFS_ATTRIBUTE(conn_info_max_age_fops, conn_info_max_age_get,
269+
conn_info_max_age_set, "%llu\n");
270270

271271
static ssize_t use_debug_keys_read(struct file *file, char __user *user_buf,
272272
size_t count, loff_t *ppos)
@@ -419,8 +419,8 @@ static int voice_setting_get(void *data, u64 *val)
419419
return 0;
420420
}
421421

422-
DEFINE_SIMPLE_ATTRIBUTE(voice_setting_fops, voice_setting_get,
423-
NULL, "0x%4.4llx\n");
422+
DEFINE_DEBUGFS_ATTRIBUTE(voice_setting_fops, voice_setting_get,
423+
NULL, "0x%4.4llx\n");
424424

425425
static ssize_t ssp_debug_mode_read(struct file *file, char __user *user_buf,
426426
size_t count, loff_t *ppos)
@@ -476,9 +476,9 @@ static int min_encrypt_key_size_get(void *data, u64 *val)
476476
return 0;
477477
}
478478

479-
DEFINE_SIMPLE_ATTRIBUTE(min_encrypt_key_size_fops,
480-
min_encrypt_key_size_get,
481-
min_encrypt_key_size_set, "%llu\n");
479+
DEFINE_DEBUGFS_ATTRIBUTE(min_encrypt_key_size_fops,
480+
min_encrypt_key_size_get,
481+
min_encrypt_key_size_set, "%llu\n");
482482

483483
static int auto_accept_delay_get(void *data, u64 *val)
484484
{
@@ -491,8 +491,8 @@ static int auto_accept_delay_get(void *data, u64 *val)
491491
return 0;
492492
}
493493

494-
DEFINE_SIMPLE_ATTRIBUTE(auto_accept_delay_fops, auto_accept_delay_get,
495-
auto_accept_delay_set, "%llu\n");
494+
DEFINE_DEBUGFS_ATTRIBUTE(auto_accept_delay_fops, auto_accept_delay_get,
495+
auto_accept_delay_set, "%llu\n");
496496

497497
static ssize_t force_bredr_smp_read(struct file *file,
498498
char __user *user_buf,
@@ -558,8 +558,8 @@ static int idle_timeout_get(void *data, u64 *val)
558558
return 0;
559559
}
560560

561-
DEFINE_SIMPLE_ATTRIBUTE(idle_timeout_fops, idle_timeout_get,
562-
idle_timeout_set, "%llu\n");
561+
DEFINE_DEBUGFS_ATTRIBUTE(idle_timeout_fops, idle_timeout_get,
562+
idle_timeout_set, "%llu\n");
563563

564564
static int sniff_min_interval_set(void *data, u64 val)
565565
{
@@ -586,8 +586,8 @@ static int sniff_min_interval_get(void *data, u64 *val)
586586
return 0;
587587
}
588588

589-
DEFINE_SIMPLE_ATTRIBUTE(sniff_min_interval_fops, sniff_min_interval_get,
590-
sniff_min_interval_set, "%llu\n");
589+
DEFINE_DEBUGFS_ATTRIBUTE(sniff_min_interval_fops, sniff_min_interval_get,
590+
sniff_min_interval_set, "%llu\n");
591591

592592
static int sniff_max_interval_set(void *data, u64 val)
593593
{
@@ -614,8 +614,8 @@ static int sniff_max_interval_get(void *data, u64 *val)
614614
return 0;
615615
}
616616

617-
DEFINE_SIMPLE_ATTRIBUTE(sniff_max_interval_fops, sniff_max_interval_get,
618-
sniff_max_interval_set, "%llu\n");
617+
DEFINE_DEBUGFS_ATTRIBUTE(sniff_max_interval_fops, sniff_max_interval_get,
618+
sniff_max_interval_set, "%llu\n");
619619

620620
void hci_debugfs_create_bredr(struct hci_dev *hdev)
621621
{
@@ -706,8 +706,8 @@ static int rpa_timeout_get(void *data, u64 *val)
706706
return 0;
707707
}
708708

709-
DEFINE_SIMPLE_ATTRIBUTE(rpa_timeout_fops, rpa_timeout_get,
710-
rpa_timeout_set, "%llu\n");
709+
DEFINE_DEBUGFS_ATTRIBUTE(rpa_timeout_fops, rpa_timeout_get,
710+
rpa_timeout_set, "%llu\n");
711711

712712
static int random_address_show(struct seq_file *f, void *p)
713713
{
@@ -869,8 +869,8 @@ static int conn_min_interval_get(void *data, u64 *val)
869869
return 0;
870870
}
871871

872-
DEFINE_SIMPLE_ATTRIBUTE(conn_min_interval_fops, conn_min_interval_get,
873-
conn_min_interval_set, "%llu\n");
872+
DEFINE_DEBUGFS_ATTRIBUTE(conn_min_interval_fops, conn_min_interval_get,
873+
conn_min_interval_set, "%llu\n");
874874

875875
static int conn_max_interval_set(void *data, u64 val)
876876
{
@@ -897,8 +897,8 @@ static int conn_max_interval_get(void *data, u64 *val)
897897
return 0;
898898
}
899899

900-
DEFINE_SIMPLE_ATTRIBUTE(conn_max_interval_fops, conn_max_interval_get,
901-
conn_max_interval_set, "%llu\n");
900+
DEFINE_DEBUGFS_ATTRIBUTE(conn_max_interval_fops, conn_max_interval_get,
901+
conn_max_interval_set, "%llu\n");
902902

903903
static int conn_latency_set(void *data, u64 val)
904904
{
@@ -925,8 +925,8 @@ static int conn_latency_get(void *data, u64 *val)
925925
return 0;
926926
}
927927

928-
DEFINE_SIMPLE_ATTRIBUTE(conn_latency_fops, conn_latency_get,
929-
conn_latency_set, "%llu\n");
928+
DEFINE_DEBUGFS_ATTRIBUTE(conn_latency_fops, conn_latency_get,
929+
conn_latency_set, "%llu\n");
930930

931931
static int supervision_timeout_set(void *data, u64 val)
932932
{
@@ -953,8 +953,8 @@ static int supervision_timeout_get(void *data, u64 *val)
953953
return 0;
954954
}
955955

956-
DEFINE_SIMPLE_ATTRIBUTE(supervision_timeout_fops, supervision_timeout_get,
957-
supervision_timeout_set, "%llu\n");
956+
DEFINE_DEBUGFS_ATTRIBUTE(supervision_timeout_fops, supervision_timeout_get,
957+
supervision_timeout_set, "%llu\n");
958958

959959
static int adv_channel_map_set(void *data, u64 val)
960960
{
@@ -981,8 +981,8 @@ static int adv_channel_map_get(void *data, u64 *val)
981981
return 0;
982982
}
983983

984-
DEFINE_SIMPLE_ATTRIBUTE(adv_channel_map_fops, adv_channel_map_get,
985-
adv_channel_map_set, "%llu\n");
984+
DEFINE_DEBUGFS_ATTRIBUTE(adv_channel_map_fops, adv_channel_map_get,
985+
adv_channel_map_set, "%llu\n");
986986

987987
static int adv_min_interval_set(void *data, u64 val)
988988
{
@@ -1009,8 +1009,8 @@ static int adv_min_interval_get(void *data, u64 *val)
10091009
return 0;
10101010
}
10111011

1012-
DEFINE_SIMPLE_ATTRIBUTE(adv_min_interval_fops, adv_min_interval_get,
1013-
adv_min_interval_set, "%llu\n");
1012+
DEFINE_DEBUGFS_ATTRIBUTE(adv_min_interval_fops, adv_min_interval_get,
1013+
adv_min_interval_set, "%llu\n");
10141014

10151015
static int adv_max_interval_set(void *data, u64 val)
10161016
{
@@ -1037,8 +1037,8 @@ static int adv_max_interval_get(void *data, u64 *val)
10371037
return 0;
10381038
}
10391039

1040-
DEFINE_SIMPLE_ATTRIBUTE(adv_max_interval_fops, adv_max_interval_get,
1041-
adv_max_interval_set, "%llu\n");
1040+
DEFINE_DEBUGFS_ATTRIBUTE(adv_max_interval_fops, adv_max_interval_get,
1041+
adv_max_interval_set, "%llu\n");
10421042

10431043
static int min_key_size_set(void *data, u64 val)
10441044
{
@@ -1065,8 +1065,8 @@ static int min_key_size_get(void *data, u64 *val)
10651065
return 0;
10661066
}
10671067

1068-
DEFINE_SIMPLE_ATTRIBUTE(min_key_size_fops, min_key_size_get,
1069-
min_key_size_set, "%llu\n");
1068+
DEFINE_DEBUGFS_ATTRIBUTE(min_key_size_fops, min_key_size_get,
1069+
min_key_size_set, "%llu\n");
10701070

10711071
static int max_key_size_set(void *data, u64 val)
10721072
{
@@ -1093,8 +1093,8 @@ static int max_key_size_get(void *data, u64 *val)
10931093
return 0;
10941094
}
10951095

1096-
DEFINE_SIMPLE_ATTRIBUTE(max_key_size_fops, max_key_size_get,
1097-
max_key_size_set, "%llu\n");
1096+
DEFINE_DEBUGFS_ATTRIBUTE(max_key_size_fops, max_key_size_get,
1097+
max_key_size_set, "%llu\n");
10981098

10991099
static int auth_payload_timeout_set(void *data, u64 val)
11001100
{
@@ -1121,9 +1121,9 @@ static int auth_payload_timeout_get(void *data, u64 *val)
11211121
return 0;
11221122
}
11231123

1124-
DEFINE_SIMPLE_ATTRIBUTE(auth_payload_timeout_fops,
1125-
auth_payload_timeout_get,
1126-
auth_payload_timeout_set, "%llu\n");
1124+
DEFINE_DEBUGFS_ATTRIBUTE(auth_payload_timeout_fops,
1125+
auth_payload_timeout_get,
1126+
auth_payload_timeout_set, "%llu\n");
11271127

11281128
static ssize_t force_no_mitm_read(struct file *file,
11291129
char __user *user_buf,

0 commit comments

Comments
 (0)