xfs: quota: fix missed destroy of qi_tree_lock

Aliaksei Karaliou · djwong · commit 219688156622 · 2018-01-02T10:16:32.000-08:00
xfs_qm_destroy_quotainfo() does not destroy quotainfo-&gt;qi_tree_lock
while destroys quotainfo-&gt;qi_quotaofflock.

Signed-off-by: Aliaksei Karaliou &lt;akaraliou.dev@gmail.com&gt;
Reviewed-by: Darrick J. Wong &lt;darrick.wong@oracle.com&gt;
Signed-off-by: Darrick J. Wong &lt;darrick.wong@oracle.com&gt;
diff --git a/fs/xfs/xfs_qm.c b/fs/xfs/xfs_qm.c
@@ -736,6 +736,7 @@ xfs_qm_destroy_quotainfo(
 		IRELE(qi->qi_pquotaip);
 		qi->qi_pquotaip = NULL;
 	}
+	mutex_destroy(&qi->qi_tree_lock);
 	mutex_destroy(&qi->qi_quotaofflock);
 	kmem_free(qi);
 	mp->m_quotainfo = NULL;

Original file line number	Diff line number	Diff line change
`@@ -736,6 +736,7 @@ xfs_qm_destroy_quotainfo(`
`736`	`736`	`IRELE(qi->qi_pquotaip);`
`737`	`737`	`qi->qi_pquotaip = NULL;`
`738`	`738`	`}`
	`739`	`+ mutex_destroy(&qi->qi_tree_lock);`
`739`	`740`	`mutex_destroy(&qi->qi_quotaofflock);`
`740`	`741`	`kmem_free(qi);`
`741`	`742`	`mp->m_quotainfo = NULL;`