Skip to content

Commit 1105304

Browse files
Russell King (Oracle)kuba-moo
authored andcommitted
net: ag71xx: remove unnecessary legacy methods
ag71xx may have a PCS, but it does not appear to support configuration of the PCS in the current code. The functions to get its state merely report that the link is down, and the AN restart function is empty. Since neither of these functions will be called unless phylink's legacy flag is set, we can safely remove these functions and indicate this is a modern driver. Should PCS support be added later, it will need to be modelled using the phylink_pcs support rather than operating as a legacy driver. Signed-off-by: Russell King (Oracle) <[email protected]> Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 001f426 commit 1105304

File tree

1 file changed

+0
-13
lines changed

1 file changed

+0
-13
lines changed

drivers/net/ethernet/atheros/ag71xx.c

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1024,17 +1024,6 @@ static void ag71xx_mac_config(struct phylink_config *config, unsigned int mode,
10241024
ag71xx_wr(ag, AG71XX_REG_FIFO_CFG3, ag->fifodata[2]);
10251025
}
10261026

1027-
static void ag71xx_mac_pcs_get_state(struct phylink_config *config,
1028-
struct phylink_link_state *state)
1029-
{
1030-
state->link = 0;
1031-
}
1032-
1033-
static void ag71xx_mac_an_restart(struct phylink_config *config)
1034-
{
1035-
/* Not Supported */
1036-
}
1037-
10381027
static void ag71xx_mac_link_down(struct phylink_config *config,
10391028
unsigned int mode, phy_interface_t interface)
10401029
{
@@ -1098,8 +1087,6 @@ static void ag71xx_mac_link_up(struct phylink_config *config,
10981087

10991088
static const struct phylink_mac_ops ag71xx_phylink_mac_ops = {
11001089
.validate = phylink_generic_validate,
1101-
.mac_pcs_get_state = ag71xx_mac_pcs_get_state,
1102-
.mac_an_restart = ag71xx_mac_an_restart,
11031090
.mac_config = ag71xx_mac_config,
11041091
.mac_link_down = ag71xx_mac_link_down,
11051092
.mac_link_up = ag71xx_mac_link_up,

0 commit comments

Comments
 (0)