Skip to content

Commit 1021275

Browse files
committed
ACPI: video: Drop NL5x?U, PF4NU1F and PF5?U?? acpi_backlight=native quirks
acpi_backlight=native is the default for these, but as the comment explains the quirk was still necessary because even briefly registering the acpi_video0 backlight; and then unregistering it once the native driver showed up, was leading to issues. After the "ACPI: video: Make backlight class device registration a separate step" patch from earlier in this patch-series, we no longer briefly register the acpi_video0 backlight on systems where the native driver should be used. So this is no longer an issue an the quirks are no longer needed. Link: https://bugzilla.kernel.org/show_bug.cgi?id=215683 Tested-by: Werner Sembach <[email protected]> Acked-by: Rafael J. Wysocki <[email protected]> Signed-off-by: Hans de Goede <[email protected]>
1 parent de6f312 commit 1021275

File tree

1 file changed

+1
-91
lines changed

1 file changed

+1
-91
lines changed

drivers/acpi/video_detect.c

Lines changed: 1 addition & 91 deletions
Original file line numberDiff line numberDiff line change
@@ -609,97 +609,7 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
609609
DMI_MATCH(DMI_BOARD_NAME, "N250P"),
610610
},
611611
},
612-
/*
613-
* Clevo NL5xRU and NL5xNU/TUXEDO Aura 15 Gen1 and Gen2 have both a
614-
* working native and video interface. However the default detection
615-
* mechanism first registers the video interface before unregistering
616-
* it again and switching to the native interface during boot. This
617-
* results in a dangling SBIOS request for backlight change for some
618-
* reason, causing the backlight to switch to ~2% once per boot on the
619-
* first power cord connect or disconnect event. Setting the native
620-
* interface explicitly circumvents this buggy behaviour, by avoiding
621-
* the unregistering process.
622-
*/
623-
{
624-
.callback = video_detect_force_native,
625-
.ident = "Clevo NL5xRU",
626-
.matches = {
627-
DMI_MATCH(DMI_BOARD_NAME, "NL5xRU"),
628-
},
629-
},
630-
{
631-
.callback = video_detect_force_native,
632-
.ident = "Clevo NL5xRU",
633-
.matches = {
634-
DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"),
635-
DMI_MATCH(DMI_BOARD_NAME, "AURA1501"),
636-
},
637-
},
638-
{
639-
.callback = video_detect_force_native,
640-
.ident = "Clevo NL5xRU",
641-
.matches = {
642-
DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"),
643-
DMI_MATCH(DMI_BOARD_NAME, "EDUBOOK1502"),
644-
},
645-
},
646-
{
647-
.callback = video_detect_force_native,
648-
.ident = "Clevo NL5xNU",
649-
.matches = {
650-
DMI_MATCH(DMI_BOARD_NAME, "NL5xNU"),
651-
},
652-
},
653-
/*
654-
* The TongFang PF5PU1G, PF4NU1F, PF5NU1G, and PF5LUXG/TUXEDO BA15 Gen10,
655-
* Pulse 14/15 Gen1, and Pulse 15 Gen2 have the same problem as the Clevo
656-
* NL5xRU and NL5xNU/TUXEDO Aura 15 Gen1 and Gen2. See the description
657-
* above.
658-
*/
659-
{
660-
.callback = video_detect_force_native,
661-
.ident = "TongFang PF5PU1G",
662-
.matches = {
663-
DMI_MATCH(DMI_BOARD_NAME, "PF5PU1G"),
664-
},
665-
},
666-
{
667-
.callback = video_detect_force_native,
668-
.ident = "TongFang PF4NU1F",
669-
.matches = {
670-
DMI_MATCH(DMI_BOARD_NAME, "PF4NU1F"),
671-
},
672-
},
673-
{
674-
.callback = video_detect_force_native,
675-
.ident = "TongFang PF4NU1F",
676-
.matches = {
677-
DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"),
678-
DMI_MATCH(DMI_BOARD_NAME, "PULSE1401"),
679-
},
680-
},
681-
{
682-
.callback = video_detect_force_native,
683-
.ident = "TongFang PF5NU1G",
684-
.matches = {
685-
DMI_MATCH(DMI_BOARD_NAME, "PF5NU1G"),
686-
},
687-
},
688-
{
689-
.callback = video_detect_force_native,
690-
.ident = "TongFang PF5NU1G",
691-
.matches = {
692-
DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"),
693-
DMI_MATCH(DMI_BOARD_NAME, "PULSE1501"),
694-
},
695-
},
696-
{
697-
.callback = video_detect_force_native,
698-
.ident = "TongFang PF5LUXG",
699-
.matches = {
700-
DMI_MATCH(DMI_BOARD_NAME, "PF5LUXG"),
701-
},
702-
},
612+
703613
/*
704614
* Desktops which falsely report a backlight and which our heuristics
705615
* for this do not catch.

0 commit comments

Comments
 (0)