Skip to content

Commit 0f66114

Browse files
gormanmtorvalds
authored andcommitted
mm, mmzone: clarify the usage of zone padding
Zone padding separates write-intensive fields used by page allocation, compaction and vmstats but the comments are a little misleading and need clarification. Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Mel Gorman <[email protected]> Cc: Hillf Danton <[email protected]> Acked-by: Johannes Weiner <[email protected]> Cc: Joonsoo Kim <[email protected]> Cc: Michal Hocko <[email protected]> Cc: Minchan Kim <[email protected]> Cc: Rik van Riel <[email protected]> Cc: Vlastimil Babka <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent 599d0c9 commit 0f66114

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

include/linux/mmzone.h

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -477,20 +477,21 @@ struct zone {
477477
unsigned long wait_table_hash_nr_entries;
478478
unsigned long wait_table_bits;
479479

480+
/* Write-intensive fields used from the page allocator */
480481
ZONE_PADDING(_pad1_)
482+
481483
/* free areas of different sizes */
482484
struct free_area free_area[MAX_ORDER];
483485

484486
/* zone flags, see below */
485487
unsigned long flags;
486488

487-
/* Write-intensive fields used from the page allocator */
489+
/* Primarily protects free_area */
488490
spinlock_t lock;
489491

492+
/* Write-intensive fields used by compaction and vmstats. */
490493
ZONE_PADDING(_pad2_)
491494

492-
/* Write-intensive fields used by page reclaim */
493-
494495
/*
495496
* When free pages are below this point, additional steps are taken
496497
* when reading the number of free pages to avoid per-cpu counter

0 commit comments

Comments
 (0)