Skip to content

Commit 049f560

Browse files
committed
Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf
Pablo Neira Ayuso says: ==================== Netfilter fixes for net The following patchset contains Netfilter fixes for net: 1) Make sure we don't go over the maximum jump stack boundary, from Taehee Yoo. 2) Missing rcu_barrier() in hash and rbtree sets, also from Taehee. 3) Missing check to nul-node in rbtree timeout routine, from Taehee. 4) Use dev->name from flowtable to fix a memleak, from Florian. 5) Oneliner to free flowtable object on removal, from Florian. 6) Memleak in chain rename transaction, again from Florian. 7) Don't allow two chains to use the same name in the same transaction, from Florian. 8) handle DCCP SYNC/SYNCACK as invalid, this triggers an uninitialized timer in conntrack reported by syzbot, from Florian. 9) Fix leak in case netlink_dump_start() fails, from Florian. ==================== Signed-off-by: David S. Miller <[email protected]>
2 parents e1adf31 + 90fd131 commit 049f560

File tree

7 files changed

+191
-150
lines changed

7 files changed

+191
-150
lines changed

include/net/netfilter/nf_tables.h

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,7 @@ static inline void nft_data_debug(const struct nft_data *data)
150150
* @portid: netlink portID of the original message
151151
* @seq: netlink sequence number
152152
* @family: protocol family
153+
* @level: depth of the chains
153154
* @report: notify via unicast netlink message
154155
*/
155156
struct nft_ctx {
@@ -160,6 +161,7 @@ struct nft_ctx {
160161
u32 portid;
161162
u32 seq;
162163
u8 family;
164+
u8 level;
163165
bool report;
164166
};
165167

@@ -865,7 +867,6 @@ enum nft_chain_flags {
865867
* @table: table that this chain belongs to
866868
* @handle: chain handle
867869
* @use: number of jump references to this chain
868-
* @level: length of longest path to this chain
869870
* @flags: bitmask of enum nft_chain_flags
870871
* @name: name of the chain
871872
*/
@@ -878,7 +879,6 @@ struct nft_chain {
878879
struct nft_table *table;
879880
u64 handle;
880881
u32 use;
881-
u16 level;
882882
u8 flags:6,
883883
genmask:2;
884884
char *name;
@@ -1124,7 +1124,6 @@ struct nft_flowtable {
11241124
u32 genmask:2,
11251125
use:30;
11261126
u64 handle;
1127-
char *dev_name[NFT_FLOWTABLE_DEVICE_MAX];
11281127
/* runtime data below here */
11291128
struct nf_hook_ops *ops ____cacheline_aligned;
11301129
struct nf_flowtable data;

net/netfilter/nf_conntrack_proto_dccp.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -243,14 +243,14 @@ dccp_state_table[CT_DCCP_ROLE_MAX + 1][DCCP_PKT_SYNCACK + 1][CT_DCCP_MAX + 1] =
243243
* We currently ignore Sync packets
244244
*
245245
* sNO, sRQ, sRS, sPO, sOP, sCR, sCG, sTW */
246-
sIG, sIG, sIG, sIG, sIG, sIG, sIG, sIG,
246+
sIV, sIG, sIG, sIG, sIG, sIG, sIG, sIG,
247247
},
248248
[DCCP_PKT_SYNCACK] = {
249249
/*
250250
* We currently ignore SyncAck packets
251251
*
252252
* sNO, sRQ, sRS, sPO, sOP, sCR, sCG, sTW */
253-
sIG, sIG, sIG, sIG, sIG, sIG, sIG, sIG,
253+
sIV, sIG, sIG, sIG, sIG, sIG, sIG, sIG,
254254
},
255255
},
256256
[CT_DCCP_ROLE_SERVER] = {
@@ -371,14 +371,14 @@ dccp_state_table[CT_DCCP_ROLE_MAX + 1][DCCP_PKT_SYNCACK + 1][CT_DCCP_MAX + 1] =
371371
* We currently ignore Sync packets
372372
*
373373
* sNO, sRQ, sRS, sPO, sOP, sCR, sCG, sTW */
374-
sIG, sIG, sIG, sIG, sIG, sIG, sIG, sIG,
374+
sIV, sIG, sIG, sIG, sIG, sIG, sIG, sIG,
375375
},
376376
[DCCP_PKT_SYNCACK] = {
377377
/*
378378
* We currently ignore SyncAck packets
379379
*
380380
* sNO, sRQ, sRS, sPO, sOP, sCR, sCG, sTW */
381-
sIG, sIG, sIG, sIG, sIG, sIG, sIG, sIG,
381+
sIV, sIG, sIG, sIG, sIG, sIG, sIG, sIG,
382382
},
383383
},
384384
};

0 commit comments

Comments
 (0)