Skip to content

Commit 0299fae

Browse files
bcreeley13anguy11
authored andcommitted
ice: Remove toggling of antispoof for VF trusted promiscuous mode
Currently when a trusted VF enables promiscuous mode spoofchk will be disabled. This is wrong and should only be modified from the ndo_set_vf_spoofchk callback. Fix this by removing the call to toggle spoofchk for trusted VFs. Fixes: 01b5e89 ("ice: Add VF promiscuous support") Signed-off-by: Brett Creeley <[email protected]> Tested-by: Tony Brelinski <[email protected]> Signed-off-by: Tony Nguyen <[email protected]>
1 parent 1a8c777 commit 0299fae

File tree

1 file changed

+0
-18
lines changed

1 file changed

+0
-18
lines changed

drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -3055,24 +3055,6 @@ static int ice_vc_cfg_promiscuous_mode_msg(struct ice_vf *vf, u8 *msg)
30553055
rm_promisc = !allmulti && !alluni;
30563056

30573057
if (vsi->num_vlan || vf->port_vlan_info) {
3058-
struct ice_vsi *pf_vsi = ice_get_main_vsi(pf);
3059-
struct net_device *pf_netdev;
3060-
3061-
if (!pf_vsi) {
3062-
v_ret = VIRTCHNL_STATUS_ERR_PARAM;
3063-
goto error_param;
3064-
}
3065-
3066-
pf_netdev = pf_vsi->netdev;
3067-
3068-
ret = ice_set_vf_spoofchk(pf_netdev, vf->vf_id, rm_promisc);
3069-
if (ret) {
3070-
dev_err(dev, "Failed to update spoofchk to %s for VF %d VSI %d when setting promiscuous mode\n",
3071-
rm_promisc ? "ON" : "OFF", vf->vf_id,
3072-
vsi->vsi_num);
3073-
v_ret = VIRTCHNL_STATUS_ERR_PARAM;
3074-
}
3075-
30763058
if (rm_promisc)
30773059
ret = ice_cfg_vlan_pruning(vsi, true);
30783060
else

0 commit comments

Comments
 (0)