fix(specs): partial update operation #3486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
Contributor
Author
|
hmmm, maybe it'll be difficult to discriminate between model types for the code generation. |
Contributor
Author
|
This affects a user now in algolia/algoliasearch-client-javascript#1542 |
shortcuts
force-pushed
the
fix/partial-update
branch
from
71a9aa9 to
3fe6174
Compare
shortcuts
approved these changes
Aug 28, 2024
Member
shortcuts
left a comment
shortcuts
left a comment
There was a problem hiding this comment.
awesome!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
algolia-bot
added a commit
that referenced
this pull request
Aug 28, 2024
Co-authored-by: Kai Welke <[email protected]> Co-authored-by: shortcuts <[email protected]> Co-authored-by: Pierre Millot <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-csharp
that referenced
this pull request
Aug 28, 2024
algolia/api-clients-automation#3486 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Kai Welke <[email protected]> Co-authored-by: shortcuts <[email protected]> Co-authored-by: Pierre Millot <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-dart
that referenced
this pull request
Aug 28, 2024
algolia/api-clients-automation#3486 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Kai Welke <[email protected]> Co-authored-by: shortcuts <[email protected]> Co-authored-by: Pierre Millot <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-go
that referenced
this pull request
Aug 28, 2024
algolia/api-clients-automation#3486 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Kai Welke <[email protected]> Co-authored-by: shortcuts <[email protected]> Co-authored-by: Pierre Millot <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-java
that referenced
this pull request
Aug 28, 2024
algolia/api-clients-automation#3486 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Kai Welke <[email protected]> Co-authored-by: shortcuts <[email protected]> Co-authored-by: Pierre Millot <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Aug 28, 2024
algolia/api-clients-automation#3486 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Kai Welke <[email protected]> Co-authored-by: shortcuts <[email protected]> Co-authored-by: Pierre Millot <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-kotlin
that referenced
this pull request
Aug 28, 2024
algolia/api-clients-automation#3486 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Kai Welke <[email protected]> Co-authored-by: shortcuts <[email protected]> Co-authored-by: Pierre Millot <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-php
that referenced
this pull request
Aug 28, 2024
algolia/api-clients-automation#3486 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Kai Welke <[email protected]> Co-authored-by: shortcuts <[email protected]> Co-authored-by: Pierre Millot <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-python
that referenced
this pull request
Aug 28, 2024
algolia/api-clients-automation#3486 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Kai Welke <[email protected]> Co-authored-by: shortcuts <[email protected]> Co-authored-by: Pierre Millot <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-ruby
that referenced
this pull request
Aug 28, 2024
algolia/api-clients-automation#3486 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Kai Welke <[email protected]> Co-authored-by: shortcuts <[email protected]> Co-authored-by: Pierre Millot <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-scala
that referenced
this pull request
Aug 28, 2024
algolia/api-clients-automation#3486 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Kai Welke <[email protected]> Co-authored-by: shortcuts <[email protected]> Co-authored-by: Pierre Millot <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-swift
that referenced
this pull request
Aug 28, 2024
algolia/api-clients-automation#3486 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Kai Welke <[email protected]> Co-authored-by: shortcuts <[email protected]> Co-authored-by: Pierre Millot <[email protected]>
medicindev
pushed a commit
to medicindev/Algolia-Client--JavaScript
that referenced
this pull request
Mar 8, 2025
algolia/api-clients-automation#3486 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Kai Welke <[email protected]> Co-authored-by: shortcuts <[email protected]> Co-authored-by: Pierre Millot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
close algolia/algoliasearch-client-javascript#1542
https://algolia.atlassian.net/browse/DI-2830
The partial update object operation accepts either a built-in operation or a new value for an attribute, which can be any type. Currently, only "built-in operation" and "string" are accepted.
Changes included:
attributeToUpdateoneOf to accept any type in addition to thebuiltInOperationmodel.