From 36f7fc72daf876637221d45d5b0a7090495b2eb7 Mon Sep 17 00:00:00 2001 From: Raed Date: Thu, 14 Dec 2023 12:06:02 +0100 Subject: [PATCH] fix(recommend): update TrendingFacetHit facetValue type to string --- packages/recommend/src/types/TrendingFacetHit.ts | 4 ++-- packages/recommend/src/types/TrendingFacetsResponse.ts | 4 ++-- packages/recommend/src/types/WithRecommendMethods.ts | 6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/recommend/src/types/TrendingFacetHit.ts b/packages/recommend/src/types/TrendingFacetHit.ts index 5b152f032..6507225bd 100644 --- a/packages/recommend/src/types/TrendingFacetHit.ts +++ b/packages/recommend/src/types/TrendingFacetHit.ts @@ -1,5 +1,5 @@ -export type TrendingFacetHit = { +export type TrendingFacetHit = { readonly _score: number; readonly facetName: string; - readonly facetValue: TObject; + readonly facetValue: string; }; diff --git a/packages/recommend/src/types/TrendingFacetsResponse.ts b/packages/recommend/src/types/TrendingFacetsResponse.ts index db074bd4a..de0658e59 100644 --- a/packages/recommend/src/types/TrendingFacetsResponse.ts +++ b/packages/recommend/src/types/TrendingFacetsResponse.ts @@ -2,6 +2,6 @@ import { SearchResponse } from '@algolia/client-search'; import { TrendingFacetHit } from './TrendingFacetHit'; -export type TrendingFacetsResponse = Omit, 'hits'> & { - readonly hits: ReadonlyArray>; +export type TrendingFacetsResponse = Omit & { + readonly hits: readonly TrendingFacetHit[]; }; diff --git a/packages/recommend/src/types/WithRecommendMethods.ts b/packages/recommend/src/types/WithRecommendMethods.ts index d51be5bf2..fde4b88a7 100644 --- a/packages/recommend/src/types/WithRecommendMethods.ts +++ b/packages/recommend/src/types/WithRecommendMethods.ts @@ -11,11 +11,11 @@ import { TrendingFacetsResponse } from './TrendingFacetsResponse'; import { TrendingItemsQuery } from './TrendingItemsQuery'; import { TrendingQuery } from './TrendingQuery'; -export type RecommendTrendingFacetsQueriesResponse = { +export type RecommendTrendingFacetsQueriesResponse = { /** * The list of results. */ - readonly results: ReadonlyArray>; + readonly results: readonly TrendingFacetsResponse[]; }; export type RecommendQueriesResponse = { @@ -64,7 +64,7 @@ export type WithRecommendMethods = TType & { readonly getTrendingFacets: ( queries: readonly TrendingFacetsQuery[], requestOptions?: RequestOptions & SearchOptions - ) => Readonly>>; + ) => Readonly>; /** * Returns Looking Similar