Skip to content

Commit cd17522

Browse files
committed
commit suggestions
1 parent 494ad39 commit cd17522

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed

src/aleph/db/accessors/messages.py

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import datetime as dt
22
import traceback
3-
import warnings
43
from typing import Optional, Sequence, Union, Iterable, Any, Mapping, overload, Tuple
54

65
from aleph_message.models import ItemHash, Chain, MessageType
@@ -90,14 +89,8 @@ def make_matching_messages_query(
9089
if chains:
9190
select_stmt = select_stmt.where(MessageDb.chain.in_(chains))
9291
if message_types:
93-
if len(message_types) == 1:
94-
select_stmt = select_stmt.where(MessageDb.type == message_types[0])
95-
else:
96-
select_stmt = select_stmt.where(MessageDb.type.in_(message_types))
92+
select_stmt = select_stmt.where(MessageDb.type.in_(message_types))
9793
if message_type:
98-
warnings.warn(
99-
"Warning: `msgType`/`message_type` query parameter is deprecated in favor of `msgTypes`\`message_types` and will be removed in future versions."
100-
)
10194
select_stmt = select_stmt.where(MessageDb.type == message_type)
10295
if start_datetime:
10396
select_stmt = select_stmt.where(MessageDb.time >= start_datetime)
@@ -244,6 +237,7 @@ def refresh_address_stats_mat_view(session: DbSession) -> None:
244237
def get_unconfirmed_messages(
245238
session: DbSession, limit: int = 100, chain: Optional[Chain] = None
246239
) -> Iterable[MessageDb]:
240+
247241
if chain is None:
248242
select_message_confirmations = select(message_confirmations.c.item_hash).where(
249243
message_confirmations.c.item_hash == MessageDb.item_hash

src/aleph/web/controllers/messages.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,10 +65,10 @@ class BaseMessageQueryParams(BaseModel):
6565
"-1 means most recent messages first, 1 means older messages first.",
6666
)
6767
message_type: Optional[MessageType] = Field(
68-
default=None, alias="msgType", description="[DEPRECATED] Message type."
68+
default=None, alias="msgType", description="Message type. Deprecated: use msgTypes instead"
6969
)
7070
message_types: Optional[List[MessageType]] = Field(
71-
default=None, alias="msgTypes", description="Accepted types of messages."
71+
default=None, alias="msgTypes", description="Accepted message types."
7272
)
7373
addresses: Optional[List[str]] = Field(
7474
default=None, description="Accepted values for the 'sender' field."

0 commit comments

Comments
 (0)