From bbbc259bb3556ff0390a7f7b050f077dd099245f Mon Sep 17 00:00:00 2001 From: Hugo Herter Date: Fri, 7 Jun 2024 23:54:46 +0200 Subject: [PATCH 1/2] Fix: Typing of item hashes were `str` not ItemHash --- src/aleph/sdk/client/abstract.py | 3 ++- src/aleph/sdk/client/authenticated_http.py | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/aleph/sdk/client/abstract.py b/src/aleph/sdk/client/abstract.py index 0d0d1e4e..9fce5469 100644 --- a/src/aleph/sdk/client/abstract.py +++ b/src/aleph/sdk/client/abstract.py @@ -19,6 +19,7 @@ from aleph_message.models import ( AlephMessage, + ItemHash, ItemType, MessagesResponse, MessageType, @@ -429,7 +430,7 @@ async def create_instance( @abstractmethod async def forget( self, - hashes: List[str], + hashes: List[ItemHash], reason: Optional[str], storage_engine: StorageEnum = StorageEnum.storage, channel: Optional[str] = None, diff --git a/src/aleph/sdk/client/authenticated_http.py b/src/aleph/sdk/client/authenticated_http.py index 0d708af2..755a4557 100644 --- a/src/aleph/sdk/client/authenticated_http.py +++ b/src/aleph/sdk/client/authenticated_http.py @@ -16,6 +16,7 @@ ForgetMessage, InstanceContent, InstanceMessage, + ItemHash, MessageType, PostContent, PostMessage, @@ -594,7 +595,7 @@ async def create_instance( async def forget( self, - hashes: List[str], + hashes: List[ItemHash], reason: Optional[str], storage_engine: StorageEnum = StorageEnum.storage, channel: Optional[str] = None, From bd6f43de6c8e8ccb61f438fd2ceff93c554587f1 Mon Sep 17 00:00:00 2001 From: Hugo Herter Date: Fri, 7 Jun 2024 23:55:07 +0200 Subject: [PATCH 2/2] Fix: Typing: Protocol AccountFromPrivateKey lacked method `sign_raw` --- src/aleph/sdk/types.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/aleph/sdk/types.py b/src/aleph/sdk/types.py index 2f57b280..8d17f4d4 100644 --- a/src/aleph/sdk/types.py +++ b/src/aleph/sdk/types.py @@ -32,5 +32,7 @@ class AccountFromPrivateKey(Account, Protocol): def __init__(self, private_key: bytes): ... + async def sign_raw(self, buffer: bytes) -> bytes: ... + GenericMessage = TypeVar("GenericMessage", bound=AlephMessage)